chore: aligns the provider’s reason mapping with OpenFeature#19
Open
duyhungtnn wants to merge 1 commit intomainfrom
Open
chore: aligns the provider’s reason mapping with OpenFeature#19duyhungtnn wants to merge 1 commit intomainfrom
duyhungtnn wants to merge 1 commit intomainfrom
Conversation
… generic ErrorReason and update tests to reflect this change.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aligns the provider’s reason mapping with OpenFeature by converting several Bucketeer error evaluation reasons into OpenFeature’s generic ErrorReason, and updates unit tests to match.
Changes:
- Update
convertReasonto mapErrorFlagNotFound,ErrorWrongType, andErrorUserIDNotSpecifiedtoopenfeature.ErrorReason. - Update evaluation and conversion tests to expect
openfeature.ErrorReasonfor those Bucketeer error reasons.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
pkg/provider.go |
Extends convertReason’s error-reason mapping to return openfeature.ErrorReason for additional Bucketeer error reasons. |
pkg/provider_test.go |
Updates expectations in evaluation and convertReason tests to reflect the new ErrorReason mapping. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
duyhungtnn
changed the title
Collaborator
Author
|
@nnnkkk7 Please help me to take a look |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aligns the provider’s reason mapping with OpenFeature by converting several Bucketeer error evaluation reasons into OpenFeature’s generic ErrorReason