feat: enhance provider with Bucketeer SDK integration and evaluation methods by nnnkkk7 · Pull Request #3 · bucketeer-io/openfeature-go-server-sdk

nnnkkk7 · 2025-04-21T11:51:55Z

Feature Provider implementation with Bucketeer SDK integration
Evaluation methods for 5 data types (Boolean, String, Float, Int, Object)
Mapping between Bucketeer evaluation reasons and OpenFeature reasons
Conversion logic from OpenFeature context to Bucketeer user
Comprehensive unit tests

…methods

Copilot

Pull Request Overview

This PR integrates the Bucketeer SDK into the feature provider to support evaluation methods for Boolean, String, Float, Int, and Object flag types and maps Bucketeer evaluation reasons to OpenFeature reasons.

Implements the BucketeerSDK interface with evaluation methods for various data types.
Converts OpenFeature context into a Bucketeer user and maps evaluation reasons accordingly.
Adds comprehensive unit tests for the new functionality.

Files not reviewed (1)

go.mod: Language not supported

Comments suppressed due to low confidence (1)

pkg/provider.go:120

The variable 'flag' appears to be used without a declaration in this function; please ensure it is passed as a parameter or defined within the scope to prevent undefined variable errors.

evaluation := p.sdk.BoolVariationDetails(ctx, bucketeerUser, flag, defaultValue)

pkg/provider.go

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

duyhungtnn

Hi @nnnkkk7,
Great work!

I have a few comments—please take a look.

pkg/provider.go

pkg/provider_test.go

pkg/provider.go

duyhungtnn · 2025-04-25T09:04:58Z

pkg/provider_test.go

+			assert.Equal(t, test.expectedReason, actual)
+		})
+	}
+}


Will you add the e2e tests ?

Yes!
I'll add it in another PR!

Yes, please add the document on how to initiate and use the provider, too.

duyhungtnn

Your changes look good.
I’m just wondering if we could support more data types in the OpenFeature EvaluationContext.

duyhungtnn · 2025-05-01T03:03:47Z

pkg/provider.go

+			valStr, ok := val.(string)
+			if !ok {
+				return user.User{},
+					ToPtr(openfeature.NewParseErrorResolutionError(
+						fmt.Sprintf("key %q, value %q can not be converted to string", key, val),
+					),
+					)
+			}
+			bucketeerUser.Data[key] = valStr


Suggested change

valStr, ok := val.(string)

if !ok {

return user.User{},

ToPtr(openfeature.NewParseErrorResolutionError(

fmt.Sprintf("key %q, value %q can not be converted to string", key, val),

),

)

}

bucketeerUser.Data[key] = valStr

switch v := val.(type) {

case string:

bucketeerUser.Data[key] = v

default:

jsonBytes, err := json.Marshal(v)

if err != nil {

return user.User{}, ToPtr(openfeature.NewParseErrorResolutionError(

fmt.Sprintf("key %q, value %q cannot be converted to JSON string: %v", key, val, err),

))

}

bucketeerUser.Data[key] = string(jsonBytes)

}

What do you think ?
If the val contains unsupported data types (e.g., functions, channels, circular references), json.Marshal will fail and return an error.
Otherwise, it seems good.

Thank you!
I fixed and added the test!
fix: add other data types to toBucketeerUser

duyhungtnn · 2025-05-01T03:16:07Z

pkg/provider_test.go

+			assert.Equal(t, test.expectedReason, actual)
+		})
+	}
+}


Yes, please add the document on how to initiate and use the provider, too.

duyhungtnn

LGTM 👍

feat: enhance provider with Bucketeer SDK integration and evaluation …

1957b54

…methods

nnnkkk7 force-pushed the feat/impl-methods branch from d70595e to 1957b54 Compare April 23, 2025 04:41

nnnkkk7 changed the title ~~feat: enhance provider with Bucketeer SDK integration and evaluation …~~ feat: enhance provider with Bucketeer SDK integration and evaluation methods Apr 23, 2025

nnnkkk7 marked this pull request as ready for review April 23, 2025 04:51

nnnkkk7 requested review from cre8ivejp, hvn2k1 and kakcy April 23, 2025 04:52

cre8ivejp requested a review from Copilot April 25, 2025 04:52

Copilot AI reviewed Apr 25, 2025

View reviewed changes

pkg/provider.go Outdated Show resolved Hide resolved

pkg/provider.go Outdated Show resolved Hide resolved

nnnkkk7 and others added 3 commits April 25, 2025 14:07

fix: update error message

94ea580

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

fix: update error message

06fec98

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

test: remove comments

d8f5853

nnnkkk7 requested a review from duyhungtnn April 25, 2025 07:14

duyhungtnn requested changes Apr 25, 2025

View reviewed changes

fix: fix how to convert reason

e7b1922

nnnkkk7 force-pushed the feat/impl-methods branch from 0de5986 to 0293115 Compare April 30, 2025 09:35

fix: fix how to convert user

39273ad

nnnkkk7 force-pushed the feat/impl-methods branch from 0293115 to 39273ad Compare April 30, 2025 09:47

nnnkkk7 requested a review from duyhungtnn April 30, 2025 09:55

duyhungtnn requested changes May 1, 2025

View reviewed changes

fix: add other data types to toBucketeerUser

e8f63b5

nnnkkk7 requested a review from duyhungtnn May 1, 2025 09:48

duyhungtnn approved these changes May 2, 2025

View reviewed changes

nnnkkk7 merged commit 0d3d31c into main May 7, 2025
4 checks passed

nnnkkk7 deleted the feat/impl-methods branch June 18, 2025 07:17

-			valStr, ok := val.(string)
-			if !ok {
-				return user.User{},
-					ToPtr(openfeature.NewParseErrorResolutionError(
-						fmt.Sprintf("key %q, value %q can not be converted to string", key, val),
-					),
-					)
-			}
-			bucketeerUser.Data[key] = valStr
+switch v := val.(type) {
+case string:
+	bucketeerUser.Data[key] = v
+default:
+	jsonBytes, err := json.Marshal(v)
+	if err != nil {
+		return user.User{}, ToPtr(openfeature.NewParseErrorResolutionError(
+			fmt.Sprintf("key %q, value %q cannot be converted to JSON string: %v", key, val, err),
+		))
+	}
+	bucketeerUser.Data[key] = string(jsonBytes)
+}

Conversation

nnnkkk7 commented Apr 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

duyhungtnn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

duyhungtnn Apr 25, 2025

Choose a reason for hiding this comment

Uh oh!

nnnkkk7 Apr 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

duyhungtnn May 1, 2025

Choose a reason for hiding this comment

Uh oh!

nnnkkk7 May 1, 2025

Choose a reason for hiding this comment

Uh oh!

duyhungtnn left a comment

Choose a reason for hiding this comment

Uh oh!

duyhungtnn May 1, 2025

Choose a reason for hiding this comment

Uh oh!

duyhungtnn May 1, 2025

Choose a reason for hiding this comment

Uh oh!

nnnkkk7 May 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

duyhungtnn May 1, 2025

Choose a reason for hiding this comment

Uh oh!

duyhungtnn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

nnnkkk7 commented Apr 21, 2025 •

edited

Loading

nnnkkk7 Apr 30, 2025 •

edited

Loading

nnnkkk7 May 1, 2025 •

edited

Loading