LSP ensure check diagnostics are always published#3709
Merged
emcfarlane merged 3 commits intomainfrom Mar 25, 2025
Merged
Conversation
This ensures checks diagnostics are always published to the LSP client. We adopt a worker model that runs checks in the background. On updates, the caller invalidates the previous checks. Checks are then re-evaluated and published. This ensures checks are eventually consistent.
Contributor
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
emcfarlane
changed the title
doriable
reviewed
Mar 24, 2025
Member
doriable
left a comment
doriable
left a comment
There was a problem hiding this comment.
Overall, I think the benefits of this change is that it publishes diagnostics from checks more aggressively, but I think it reintroduces some of the concerns around blocking on checks, which we are currently mitigating with a very long checkRefreshPeriod of 3s. I guess I'm somewhat okay with merging this, only because we want to fix this more generally in our upcoming LSP work.
doriable
approved these changes
Mar 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures checks diagnostics are always published to the LSP client. We adopt a worker model that runs checks in the background. On updates, the caller invalidates the previous checks. Checks are then re-evaluated and published. This ensures checks are eventually consistent.
Thanks to #3706 for finding the issue for missing check diagnostics. This fixes that issue and solves the error case where the checks are never run due to try locking.