Skip to content

Fix --exclude-type on buf generate specified inputs #3726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emcfarlane merged 3 commits into from
Mar 31, 2025
Merged

Fix --exclude-type on buf generate specified inputs #3726

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2497329
Fix exclude_types on CLI specified inputs
emcfarlane Mar 31, 2025
850ed5d
Fix typo in CHANGELOG
emcfarlane Mar 31, 2025
e6704a2
Merge branch 'main' into ed/fixExcludeTypesOnSpecified
emcfarlane Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## [Unreleased]

- Fix `exclude_type` on a non imported package.
- Fix `--exclude-type` flag for `buf generate` when an input is specified.

## [v1.51.0] - 2025-03-28

Expand Down
5 changes: 5 additions & 0 deletions private/buf/cmd/buf/command/generate/generate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -630,12 +630,17 @@ func getInputImages(
if len(includeTypesOverride) > 0 {
includeTypes = includeTypesOverride
}
var excludeTypes []string
if len(excludeTypesOverride) > 0 {
excludeTypes = excludeTypesOverride
}
inputImage, err := controller.GetImage(
ctx,
input,
bufctl.WithConfigOverride(moduleConfigOverride),
bufctl.WithTargetPaths(targetPathsOverride, excludePathsOverride),
bufctl.WithImageIncludeTypes(includeTypes),
bufctl.WithImageExcludeTypes(excludeTypes),
)
if err != nil {
return nil, err
Expand Down