Ensure deterministic order for filtered public imports#3734
Merged
emcfarlane merged 3 commits intomainfrom Apr 2, 2025
Merged
Conversation
This ensures that public imports are always added to the image in a deterministic way. It changes the current ordering by first seen to ordered by file name. First seen is not valid as when including options we range over them in a undeterministic way.
Contributor
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
doriable
reviewed
Apr 2, 2025
doriable
approved these changes
Apr 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures that public imports are always added to the image in a deterministic way. It changes the current order by first seen to order by file name. First seen is not valid as when including options we range over them in an undefined order (although from testing it looks to always be in tag order).
Related to #3506 and #3725 . Both these issues link to the same error of adding unused imports. This was fixed in #3727 . This PR fixes an edge case where if 2 or more public imports are resolved for a file, they must be appended to the current imports in a deterministic way.