Skip to content

LSP fix completion inside comments #4214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emcfarlane merged 3 commits into from
Dec 9, 2025
Merged

LSP fix completion inside comments #4214

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cd5c17e
LSP fix completion inside comments
emcfarlane Dec 9, 2025
0113f89
Add comments for isTokenXXX types
emcfarlane Dec 9, 2025
747a3ab
Cleanup
emcfarlane Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion private/buf/buflsp/completion.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1516,7 +1516,7 @@ func isTokenTypeDelimiter(tok token.Token) bool {
kind := tok.Kind()
return (kind == token.Unrecognized && tok.IsZero()) ||
(kind == token.Space && strings.IndexByte(tok.Text(), '\n') != -1) ||
(kind == token.Comment)
(kind == token.Comment && strings.HasSuffix(tok.Text(), "\n"))
}

// extractAroundOffset extracts the value around the offset by querying the token stream.
Expand Down