Skip to content

Conversation

@doriable
Copy link
Member

@doriable doriable commented Dec 15, 2025

The latest protocompile update introduces a change in the lexer
for handling newlines in comments. Formerly, newlines would be
included in the preceding comment token, but they are now separated.

To account for this, we take space tokens that are new-lines
(e.g. \n) and append them to the comment preceding. We don't need
to account for carriage returns \r\n since we only care about the \n
portion of this (this is the same behaviour as the lexer).

@github-actions
Copy link
Contributor

github-actions bot commented Dec 15, 2025

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedDec 15, 2025, 8:04 PM

@doriable doriable merged commit 1cae155 into main Dec 15, 2025
10 checks passed
@doriable doriable deleted the fix-docs-comments branch December 15, 2025 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants