Evict queries.File with ReportError set to both true and false
#4257
+43
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
emcfarlane
reviewed
Jan 5, 2026
emcfarlane
reviewed
Jan 6, 2026
emcfarlane
reviewed
Jan 6, 2026
emcfarlane
reviewed
Jan 6, 2026
emcfarlane
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes buggy behaviour found in autocompletion
after the memory leak was merged (#4230) due to stale
state being returned from
queries.Executor. This is becausewe were only evicting
queries.FilewhereReportErroris setto true, but
queries.IRdepends onqueries.FilewithReportErrorset to false, so a stale version of the
Filewas being parsed for IR.This also updates protocompile to the latest version to pull in fixes
for zero values.