Stop collecting floating comments in LSP hover#4259
Merged
stefanvanburen merged 10 commits intomainfrom Jan 6, 2026
Merged
Conversation
Contributor
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
emcfarlane
reviewed
Jan 6, 2026
We want to check for both "expectedContains" and "expectedNotContains", if set.
Now we keep track of the previous token in order to figure out if we ought to break.
emcfarlane
approved these changes
Jan 6, 2026
emcfarlane
approved these changes
Jan 6, 2026
emcfarlane
reviewed
Jan 6, 2026
doriable
approved these changes
Jan 6, 2026
emcfarlane
approved these changes
Jan 6, 2026
stefanvanburen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comments that are separated by multiple newlines (e.g.) are "floating comments" that typically don't refer directly to the next field. We ought to not include them in the hover documentation.