Merged
Conversation
Contributor
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
It looks like we dropped this out of the zap logs, way back in #69. @emcfarlane correctly ported the lack of a timestamp over to slog in #3844. This probably made sense when `buf` was running fairly quick CLI commands, but now that we have various server processes running from `buf`, it makes sense to add a timestamp for the various logs being emitted. I specifically wanted this when debugging `buf lsp serve`. We _could_ just make this optional (only for certain commands), but this feels fairly uncontroversial.
stefanvanburen
force-pushed
the
svanburen/add-timestamp-logging
branch
from
82ec0d4 to
6d888c7
Compare
Console format was updated, so we want to check for the updated format. Also, use `t.Context()` in tests instead of `context.Background()`.
doriable
approved these changes
Feb 25, 2026
stefanvanburen
added a commit
that referenced
this pull request
Feb 26, 2026
This reverts commit 04dcaf3. This doesn't look great in the CLI with our approach to warnings: Before: ```console $ buf dep update WARN Module buf.build/bufbuild/protovalidate is declared in your buf.yaml deps but is unused. This command only modifies buf.lock files, not buf.yaml files. Please remove buf.build/bufbuild/protovalidate from your buf.yaml deps if it is not needed. ``` After: ```console $ buf dep update 2026-02-26T16:53:16-05:00 WARN Module buf.build/bufbuild/protovalidate is declared in your buf.yaml deps but is unused. This command only modifies buf.lock files, not buf.yaml files. Please remove buf.build/bufbuild/protovalidate from your buf.yaml deps if it is not needed. ``` Adds a lot of noise, and we have this sort of thing in examples that we probably don't want to update (e.g., https://protovalidate.com/quickstart/connect-go/#add-protovalidate-dependency). For now, let's revert, and we could consider adding this as a more targeted addition to maybe just our server / long-running processes, on an opt-in basis.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like we dropped this out of the zap logs, way back in #69. @emcfarlane correctly ported the lack of a timestamp over to slog in #3844. This probably made sense when
bufwas running fairly quick CLI commands, but now that we have various server processes running frombuf, it makes sense to add a timestamp for the various logs being emitted. I specifically wanted this when debuggingbuf lsp serve.We could just make this optional (only for certain commands), but this feels fairly uncontroversial.