Drop googleapis/api direct dependency in LSP CEL#4356
Merged
stefanvanburen merged 4 commits intomainfrom Feb 24, 2026
Merged
Conversation
Figured out how to do this in [my weekend project][1] and figured we ought to do the same here, so we aren't tied to these representations in case cel-go drops them. Drops the direct dep (still transitive), and fixes a minor bug in representing `int`s in the hover content (instead of the Go `int64` type). [1]: https://github.com/stefanvanburen/cells
Contributor
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
emcfarlane
approved these changes
Feb 24, 2026
doriable
approved these changes
Feb 24, 2026
Member
doriable
left a comment
doriable
left a comment
There was a problem hiding this comment.
Looks good to me, feel free to merge after the lint is resolved. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Figured out how to do this in my weekend project and figured we ought to do the same here, so we aren't tied to these representations in case cel-go drops them. Drops the direct dep (still transitive), and fixes a minor bug in representing
ints in the hover content (instead of the Goint64type).