Enable usetesting lints

.golangci.yml

@@ -41,6 +41,7 @@ linters:
     - staticcheck
     - unconvert
     - unused
+    - usetesting
     - wastedassign
     - whitespace
   settings:
@@ -88,6 +89,9 @@ linters:
       require-explanation: true
       require-specific: true
       allow-unused: false
+    usetesting:
+      context-background: true
+      context-todo: true
   exclusions:
     generated: lax
     presets:

cmd/buf/buf_test.go

@@ -16,7 +16,6 @@ package main
 
 import (
 	"bytes"
-	"context"
 	"encoding/json"
 	"errors"
 	"fmt"
@@ -1356,7 +1355,7 @@ func TestCheckLsBreakingRulesFromConfigExceptDeprecated(t *testing.T) {
 			// Do not need any custom lint/breaking plugins here.
 			client, err := bufcheck.NewClient(slogtestext.NewLogger(t))
 			require.NoError(t, err)
-			allRules, err := client.AllRules(context.Background(), check.RuleTypeBreaking, version)
+			allRules, err := client.AllRules(t.Context(), check.RuleTypeBreaking, version)
 			require.NoError(t, err)
 			allPackageIDs := make([]string, 0, len(allRules))
 			for _, rule := range allRules {

cmd/buf/internal/command/alpha/protoc/protoc_test.go

@@ -16,7 +16,6 @@ package protoc
 
 import (
 	"bytes"
-	"context"
 	"fmt"
 	"os"
 	"path/filepath"
@@ -222,7 +221,7 @@ func testInsertionPointMixedPathsSuccess(t *testing.T, receiverOut string, write
 		fmt.Sprintf("--%s_out=%s", "insertion-point-writer", writerOut),
 	}
 	err := prototesting.RunProtoc(
-		context.Background(),
+		t.Context(),
 		[]string{dirPath},
 		filePaths,
 		false,
@@ -338,7 +337,7 @@ func testCompareGeneratedStubs(
 	)
 	require.NoError(t, err)
 	diff, err := storage.DiffBytes(
-		context.Background(),
+		t.Context(),
 		actualReadWriteBucket,
 		bufReadWriteBucket,
 	)
@@ -418,7 +417,7 @@ func testCompareGeneratedStubsArchive(
 	require.NoError(t, err)
 	actualReadWriteBucket := storagemem.NewReadWriteBucket()
 	err = storagearchive.Unzip(
-		context.Background(),
+		t.Context(),
 		bytes.NewReader(actualData),
 		int64(len(actualData)),
 		actualReadWriteBucket,
@@ -428,14 +427,14 @@ func testCompareGeneratedStubsArchive(
 	require.NoError(t, err)
 	bufReadWriteBucket := storagemem.NewReadWriteBucket()
 	err = storagearchive.Unzip(
-		context.Background(),
+		t.Context(),
 		bytes.NewReader(bufData),
 		int64(len(bufData)),
 		bufReadWriteBucket,
 	)
 	require.NoError(t, err)
 	diff, err := storage.DiffBytes(
-		context.Background(),
+		t.Context(),
 		actualReadWriteBucket,
 		bufReadWriteBucket,
 	)

cmd/buf/internal/command/config/configmigrate/configmigrate_test.go

@@ -16,7 +16,6 @@ package configmigrate
 
 import (
 	"bytes"
-	"context"
 	"path/filepath"
 	"testing"
 
@@ -54,7 +53,7 @@ func testCompareConfigMigrate(t *testing.T, dir string, expectCode int, expectSt
 	tempDir := t.TempDir()
 	tempBucket, err := storageosProvider.NewReadWriteBucket(tempDir)
 	require.NoError(t, err)
-	ctx := context.Background()
+	ctx := t.Context()
 	_, err = storage.Copy(ctx, inputBucket, tempBucket)
 	require.NoError(t, err)
 	var outputBucket storage.ReadWriteBucket

cmd/buf/internal/command/generate/generate_test.go

@@ -165,7 +165,7 @@ func TestGenerateV2LocalPluginBasic(t *testing.T) {
 	actual, err := storageos.NewProvider().NewReadWriteBucket(tempDirPath)
 	require.NoError(t, err)
 
-	diff, err := storage.DiffBytes(context.Background(), expected, actual)
+	diff, err := storage.DiffBytes(t.Context(), expected, actual)
 	require.NoError(t, err)
 	require.Empty(t, string(diff))
 }
@@ -188,7 +188,7 @@ func TestGenerateV2LocalPluginTypes(t *testing.T) {
 		actual, err := storageos.NewProvider().NewReadWriteBucket(tempDirPath)
 		require.NoError(t, err)
 
-		diff, err := storage.DiffBytes(context.Background(), expected, actual)
+		diff, err := storage.DiffBytes(t.Context(), expected, actual)
 		require.NoError(t, err)
 		require.Empty(t, string(diff))
 	}
@@ -657,7 +657,7 @@ func testGenerateInsertionPoint(
 ) {
 	storageosProvider := storageos.NewProvider()
 	tempDir, readWriteBucket := internaltesting.CopyReadBucketToTempDir(
-		context.Background(),
+		t.Context(),
 		t,
 		storageosProvider,
 		storagemem.NewReadWriteBucket(),
@@ -672,7 +672,7 @@ func testGenerateInsertionPoint(
 	)
 	expectedOutput, err := storageosProvider.NewReadWriteBucket(expectedOutputPath)
 	require.NoError(t, err)
-	diff, err := storage.DiffBytes(context.Background(), expectedOutput, readWriteBucket)
+	diff, err := storage.DiffBytes(t.Context(), expectedOutput, readWriteBucket)
 	require.NoError(t, err)
 	require.Empty(t, string(diff))
 }
@@ -802,7 +802,7 @@ func testCompareGeneratedStubs(
 	)
 	require.NoError(t, err)
 	diff, err := storage.DiffBytes(
-		context.Background(),
+		t.Context(),
 		actualReadWriteBucket,
 		bufReadWriteBucket,
 		transformGolangProtocVersionToUnknown(t),
@@ -864,7 +864,7 @@ func testCompareGeneratedStubsArchive(
 	require.NoError(t, err)
 	actualReadWriteBucket := storagemem.NewReadWriteBucket()
 	err = storagearchive.Unzip(
-		context.Background(),
+		t.Context(),
 		bytes.NewReader(actualData),
 		int64(len(actualData)),
 		actualReadWriteBucket,
@@ -874,14 +874,14 @@ func testCompareGeneratedStubsArchive(
 	require.NoError(t, err)
 	bufReadWriteBucket := storagemem.NewReadWriteBucket()
 	err = storagearchive.Unzip(
-		context.Background(),
+		t.Context(),
 		bytes.NewReader(bufData),
 		int64(len(bufData)),
 		bufReadWriteBucket,
 	)
 	require.NoError(t, err)
 	diff, err := storage.DiffBytes(
-		context.Background(),
+		t.Context(),
 		actualReadWriteBucket,
 		bufReadWriteBucket,
 		transformGolangProtocVersionToUnknown(t),
@@ -938,7 +938,7 @@ func testGenerateDeleteOutsWithArgAndConfig(
 			},
 		)
 	}
-	ctx := context.Background()
+	ctx := t.Context()
 	tmpDirPath := t.TempDir()
 	storageBucket, err := storageos.NewProvider().NewReadWriteBucket(tmpDirPath)
 	require.NoError(t, err)

cmd/buf/workspace_test.go

@@ -16,7 +16,6 @@ package main
 
 import (
 	"bytes"
-	"context"
 	"fmt"
 	"os"
 	"path/filepath"
@@ -1716,7 +1715,7 @@ func createZipFromDir(t *testing.T, rootPath string, archiveName string) string
 
 	buffer := bytes.NewBuffer(nil)
 	require.NoError(t, storagearchive.Zip(
-		context.Background(),
+		t.Context(),
 		testdataBucket,
 		buffer,
 		true,
@@ -1728,7 +1727,7 @@ func createZipFromDir(t *testing.T, rootPath string, archiveName string) string
 	)
 	require.NoError(t, err)
 	require.NoError(t, storage.PutPath(
-		context.Background(),
+		t.Context(),
 		zipBucket,
 		archiveName,
 		buffer.Bytes(),

cmd/protoc-gen-buf-lint/lint_test.go

@@ -301,7 +301,7 @@ func testRunHandlerFunc(
 
 	exitCode := app.GetExitCode(
 		protoplugin.Run(
-			context.Background(),
+			t.Context(),
 			protoplugin.Env{
 				Args:    nil,
 				Stdin:   stdin,
@@ -331,7 +331,7 @@ func testBuildRequest(
 	fileToGenerate []string,
 ) protoplugin.Request {
 	fileDescriptorSet, err := prototesting.GetProtocFileDescriptorSet(
-		context.Background(),
+		t.Context(),
 		[]string{root},
 		realFilePaths,
 		true,

private/buf/bufcurl/invoker_test.go

@@ -15,7 +15,6 @@
 package bufcurl
 
 import (
-	"context"
 	"os"
 	"testing"
 
@@ -32,7 +31,7 @@ func TestCountUnrecognized(t *testing.T) {
 		Resolver: &protocompile.SourceResolver{
 			ImportPaths: []string{"./testdata"},
 		},
-	}).Compile(context.Background(), "test.proto")
+	}).Compile(t.Context(), "test.proto")
 	require.NoError(t, err)
 	msgType, err := descriptors.AsResolver().FindMessageByName("foo.bar.Message")
 	require.NoError(t, err)

private/buf/buffetch/buffetch_test.go

@@ -15,7 +15,6 @@
 package buffetch
 
 import (
-	"context"
 	"io"
 	"log/slog"
 	"path/filepath"
@@ -106,7 +105,7 @@ func testRoundTripLocalFile(
 	reader := testNewFetchReader(logger)
 	writer := testNewFetchWriter(logger)
 
-	ctx := context.Background()
+	ctx := t.Context()
 	container := app.NewContainer(nil, nil, nil, nil)
 
 	tmpDir := t.TempDir()

private/buf/buffetch/internal/reader_test.go

@@ -31,7 +31,7 @@ import (
 
 func TestGetReadBucketCloserForBucketNoTerminateFileName(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 	inputBucket, err := storageos.NewProvider().NewReadWriteBucket("testdata/bufyaml/one/two")
 	require.NoError(t, err)
 	readBucketCloser, bucketTargeting, err := getReadBucketCloserForBucket(
@@ -50,7 +50,7 @@ func TestGetReadBucketCloserForBucketNoTerminateFileName(t *testing.T) {
 
 func TestGetReadBucketCloserTerminateFileName(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 	inputBucket, err := storageos.NewProvider().NewReadWriteBucket("testdata/bufyaml/one/two")
 	require.NoError(t, err)
 	readBucketCloser, bucketTargeting, err := getReadBucketCloserForBucket(
@@ -72,7 +72,7 @@ func TestGetReadBucketCloserTerminateFileName(t *testing.T) {
 
 func TestGetReadBucketCloserForBucketNoSubDirPath(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 	inputBucket, err := storageos.NewProvider().NewReadWriteBucket("testdata/bufyaml/one/two/three/four/five")
 	require.NoError(t, err)
 	readBucketCloser, bucketTargeting, err := getReadBucketCloserForBucket(
@@ -94,7 +94,7 @@ func TestGetReadBucketCloserForBucketNoSubDirPath(t *testing.T) {
 
 func TestGetReadBucketCloserForBucketAbs(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 	absDirPath, err := filepath.Abs(".")
 	require.NoError(t, err)
 	inputBucket, err := storageos.NewProvider().NewReadWriteBucket(normalpath.Join(absDirPath, "testdata/bufyaml/one/two"))
@@ -118,7 +118,7 @@ func TestGetReadBucketCloserForBucketAbs(t *testing.T) {
 
 func TestGetReadWriteBucketForOSNoTerminateFileName(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 	readWriteBucket, bucketTargeting, err := getReadWriteBucketForOS(
 		ctx,
 		slogtestext.NewLogger(t),
@@ -138,7 +138,7 @@ func TestGetReadWriteBucketForOSNoTerminateFileName(t *testing.T) {
 
 func TestGetReadWriteBucketForOSTerminateFileName(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 	readWriteBucket, bucketTargeting, err := getReadWriteBucketForOS(
 		ctx,
 		slogtestext.NewLogger(t),
@@ -162,7 +162,7 @@ func TestGetReadWriteBucketForOSTerminateFileName(t *testing.T) {
 func TestGetReadWriteBucketForOSParentPwd(t *testing.T) {
 	// Cannot be parallel since we chdir.
 
-	ctx := context.Background()
+	ctx := t.Context()
 	pwd, err := osext.Getwd()
 	require.NoError(t, err)
 	require.NoError(t, osext.Chdir(normalpath.Unnormalize(normalpath.Join(pwd, "testdata/bufyaml/one/two/three/four"))))
@@ -196,7 +196,7 @@ func TestGetReadWriteBucketForOSParentPwd(t *testing.T) {
 func TestGetReadWriteBucketForOSAbsPwd(t *testing.T) {
 	// Cannot be parallel since we chdir.
 
-	ctx := context.Background()
+	ctx := t.Context()
 	absDirPath, err := filepath.Abs(".")
 	require.NoError(t, err)
 	pwd, err := osext.Getwd()
@@ -231,7 +231,7 @@ func TestGetReadWriteBucketForOSAbsPwd(t *testing.T) {
 
 func TestGetReadBucketCloserForOSProtoFileNoWorkspaceTerminateFileName(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 	readBucketCloser, bucketTargeting, err := getReadBucketCloserForOSProtoFile(
 		ctx,
 		slogtestext.NewLogger(t),
@@ -252,7 +252,7 @@ func TestGetReadBucketCloserForOSProtoFileNoWorkspaceTerminateFileName(t *testin
 
 func TestGetReadBucketCloserForOSProtoFileTerminateFileName(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 	readBucketCloser, bucketTargeting, err := getReadBucketCloserForOSProtoFile(
 		ctx,
 		slogtestext.NewLogger(t),
@@ -277,7 +277,7 @@ func TestGetReadBucketCloserForOSProtoFileTerminateFileName(t *testing.T) {
 func TestGetReadBucketCloserForOSProtoFileParentPwd(t *testing.T) {
 	// Cannot be parallel since we chdir.
 
-	ctx := context.Background()
+	ctx := t.Context()
 	pwd, err := osext.Getwd()
 	require.NoError(t, err)
 	require.NoError(t, osext.Chdir(normalpath.Unnormalize(normalpath.Join(pwd, "testdata/bufyaml/one/two/three/four"))))
@@ -312,7 +312,7 @@ func TestGetReadBucketCloserForOSProtoFileParentPwd(t *testing.T) {
 func TestGetReadBucketCloserForOSProtoFileAbsPwd(t *testing.T) {
 	// Cannot be parallel since we chdir.
 
-	ctx := context.Background()
+	ctx := t.Context()
 	absDirPath, err := filepath.Abs(".")
 	require.NoError(t, err)
 	pwd, err := osext.Getwd()
@@ -348,7 +348,7 @@ func TestGetReadBucketCloserForOSProtoFileAbsPwd(t *testing.T) {
 
 func TestGetReadBucketCloserForOSProtoFileNoBufYAMLTerminateFileName(t *testing.T) {
 	t.Parallel()
-	ctx := context.Background()
+	ctx := t.Context()
 	readBucketCloser, bucketTargeting, err := getReadBucketCloserForOSProtoFile(
 		ctx,
 		slogtestext.NewLogger(t),
@@ -370,7 +370,7 @@ func TestGetReadBucketCloserForOSProtoFileNoBufYAMLTerminateFileName(t *testing.
 func TestGetReadBucketCloserForOSProtoFileNoBufYAMLParentPwd(t *testing.T) {
 	// Cannot be parallel since we chdir.
 
-	ctx := context.Background()
+	ctx := t.Context()
 	pwd, err := osext.Getwd()
 	require.NoError(t, err)
 	require.NoError(t, osext.Chdir(normalpath.Unnormalize(normalpath.Join(pwd, "testdata/nobufyaml/one/two/three/four"))))
@@ -406,7 +406,7 @@ func TestGetReadBucketCloserForOSProtoFileNoBufYAMLAbsPwd(t *testing.T) {
 	// Cannot be parallel since we chdir.
 	t.Skip()
 
-	ctx := context.Background()
+	ctx := t.Context()
 	absDirPath, err := filepath.Abs(".")
 	require.NoError(t, err)
 	pwd, err := osext.Getwd()