Skip to content

Found new managed modules references#832

Merged
unmultimedio merged 1 commit intomainfrom
fetch-modules
Jan 15, 2025
Merged

Found new managed modules references#832
unmultimedio merged 1 commit intomainfrom
fetch-modules

Conversation

@app-token-modules
Copy link
Contributor

New managed modules references found. Please review.

@app-token-modules app-token-modules bot requested review from a team, cyinma and jrallsn January 15, 2025 12:05
Copy link
Member

@unmultimedio unmultimedio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed envoy release, lgtm. cc @pkwarren in case you wanna have another look.

Comment on lines +32 to +33
"name": "v1.33.0",
"digest": "0f6f4339ea181ae26dd8156629ac3d40d49740ff4ba2cea29a7c393755902df2a8a5ab4140e97f28c86ca25c08b73d4610bd00d049e6fa2ed176191570b209f1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked more in detail

Release notes: https://github.com/envoyproxy/envoy/releases/tag/v1.33.0

Manifest diff

Deleted:
- envoy/config/trace/v2/opencensus.proto
- envoy/config/trace/v3/opencensus.proto
- envoy/service/trace/v2/trace_service.proto
- envoy/service/trace/v3/trace_service.proto

Added:
+ envoy/extensions/clusters/common/dns/v3/dns.proto
+ envoy/extensions/clusters/dns/v3/dns_cluster.proto
+ envoy/extensions/common/aws/v3/credential_provider.proto
+ envoy/extensions/dynamic_modules/v3/dynamic_modules.proto
+ envoy/extensions/filters/http/api_key_auth/v3/api_key_auth.proto
+ envoy/extensions/filters/http/dynamic_modules/v3/dynamic_modules.proto
+ envoy/extensions/filters/http/grpc_json_reverse_transcoder/v3/transcoder.proto
+ envoy/extensions/quic/connection_debug_visitor/quic_stats/v3/quic_stats.proto
+ envoy/type/matcher/v3/address.proto

Changed content:
- contrib/envoy/extensions/filters/network/kafka_broker/v3/kafka_broker.proto
+ contrib/envoy/extensions/filters/network/kafka_broker/v3/kafka_broker.proto
- envoy/admin/v3/config_dump_shared.proto
+ envoy/admin/v3/config_dump_shared.proto
- envoy/admin/v3/server_info.proto
+ envoy/admin/v3/server_info.proto
- envoy/config/accesslog/v3/accesslog.proto
+ envoy/config/accesslog/v3/accesslog.proto
- envoy/config/cluster/redis/redis_cluster.proto
+ envoy/config/cluster/redis/redis_cluster.proto
- envoy/config/cluster/v3/cluster.proto
+ envoy/config/cluster/v3/cluster.proto
- envoy/config/core/v3/base.proto
+ envoy/config/core/v3/base.proto
- envoy/config/core/v3/protocol.proto
+ envoy/config/core/v3/protocol.proto
- envoy/config/filter/network/http_connection_manager/v2/http_connection_manager.proto
+ envoy/config/filter/network/http_connection_manager/v2/http_connection_manager.proto
- envoy/config/filter/network/kafka_broker/v2alpha1/kafka_broker.proto
+ envoy/config/filter/network/kafka_broker/v2alpha1/kafka_broker.proto
- envoy/config/grpc_credential/v3/aws_iam.proto
+ envoy/config/grpc_credential/v3/aws_iam.proto
- envoy/config/listener/v3/listener_components.proto
+ envoy/config/listener/v3/listener_components.proto
- envoy/config/overload/v3/overload.proto
+ envoy/config/overload/v3/overload.proto
- envoy/config/rbac/v3/rbac.proto
+ envoy/config/rbac/v3/rbac.proto
- envoy/config/route/v3/route_components.proto
+ envoy/config/route/v3/route_components.proto
- envoy/config/trace/v2/http_tracer.proto
+ envoy/config/trace/v2/http_tracer.proto
- envoy/config/trace/v2/trace.proto
+ envoy/config/trace/v2/trace.proto
- envoy/config/trace/v3/trace.proto
+ envoy/config/trace/v3/trace.proto
- envoy/extensions/clusters/redis/v3/redis_cluster.proto
+ envoy/extensions/clusters/redis/v3/redis_cluster.proto
- envoy/extensions/common/ratelimit/v3/ratelimit.proto
+ envoy/extensions/common/ratelimit/v3/ratelimit.proto
- envoy/extensions/filters/http/aws_request_signing/v3/aws_request_signing.proto
+ envoy/extensions/filters/http/aws_request_signing/v3/aws_request_signing.proto
- envoy/extensions/filters/http/ext_authz/v3/ext_authz.proto
+ envoy/extensions/filters/http/ext_authz/v3/ext_authz.proto
- envoy/extensions/filters/http/ext_proc/v3/ext_proc.proto
+ envoy/extensions/filters/http/ext_proc/v3/ext_proc.proto
- envoy/extensions/filters/http/ext_proc/v3/processing_mode.proto
+ envoy/extensions/filters/http/ext_proc/v3/processing_mode.proto
- envoy/extensions/filters/http/header_mutation/v3/header_mutation.proto
+ envoy/extensions/filters/http/header_mutation/v3/header_mutation.proto
- envoy/extensions/filters/http/ip_tagging/v3/ip_tagging.proto
+ envoy/extensions/filters/http/ip_tagging/v3/ip_tagging.proto
- envoy/extensions/filters/http/oauth2/v3/oauth.proto
+ envoy/extensions/filters/http/oauth2/v3/oauth.proto
- envoy/extensions/filters/http/ratelimit/v3/rate_limit.proto
+ envoy/extensions/filters/http/ratelimit/v3/rate_limit.proto
- envoy/extensions/filters/http/stateful_session/v3/stateful_session.proto
+ envoy/extensions/filters/http/stateful_session/v3/stateful_session.proto
- envoy/extensions/filters/network/http_connection_manager/v3/http_connection_manager.proto
+ envoy/extensions/filters/network/http_connection_manager/v3/http_connection_manager.proto
- envoy/extensions/filters/network/rbac/v3/rbac.proto
+ envoy/extensions/filters/network/rbac/v3/rbac.proto
- envoy/extensions/filters/network/sni_dynamic_forward_proxy/v3/sni_dynamic_forward_proxy.proto
+ envoy/extensions/filters/network/sni_dynamic_forward_proxy/v3/sni_dynamic_forward_proxy.proto
- envoy/extensions/filters/network/tcp_proxy/v3/tcp_proxy.proto
+ envoy/extensions/filters/network/tcp_proxy/v3/tcp_proxy.proto
- envoy/extensions/filters/udp/udp_proxy/v3/udp_proxy.proto
+ envoy/extensions/filters/udp/udp_proxy/v3/udp_proxy.proto
- envoy/extensions/network/dns_resolver/cares/v3/cares_dns_resolver.proto
+ envoy/extensions/network/dns_resolver/cares/v3/cares_dns_resolver.proto
- envoy/extensions/transport_sockets/proxy_protocol/v3/upstream_proxy_protocol.proto
+ envoy/extensions/transport_sockets/proxy_protocol/v3/upstream_proxy_protocol.proto
- envoy/extensions/transport_sockets/tls/v3/common.proto
+ envoy/extensions/transport_sockets/tls/v3/common.proto
- envoy/extensions/transport_sockets/tls/v3/tls.proto
+ envoy/extensions/transport_sockets/tls/v3/tls.proto
- envoy/extensions/wasm/v3/wasm.proto
+ envoy/extensions/wasm/v3/wasm.proto
- envoy/service/discovery/v3/discovery.proto
+ envoy/service/discovery/v3/discovery.proto
- envoy/service/ext_proc/v3/external_processor.proto
+ envoy/service/ext_proc/v3/external_processor.proto
- envoy/service/ratelimit/v3/rls.proto
+ envoy/service/ratelimit/v3/rls.proto
- envoy/service/status/v3/csds.proto
+ envoy/service/status/v3/csds.proto
- envoy/type/matcher/v3/filter_state.proto
+ envoy/type/matcher/v3/filter_state.proto
- envoy/type/v3/http_status.proto
+ envoy/type/v3/http_status.proto

Interesting bits:

Tracing:

  • Removed support for (long deprecated) Opencensus tracing extension.

That's a breaking change. The only other managed module dependent on this module is envoyproxy/ratelimit, although they don't seem to import it:

SCR-20250115-kils SCR-20250115-kiva

@unmultimedio unmultimedio merged commit 79f1617 into main Jan 15, 2025
5 checks passed
@unmultimedio unmultimedio deleted the fetch-modules branch January 15, 2025 17:56
@unmultimedio unmultimedio mentioned this pull request Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant