Skip to content

Found new managed modules references#912

Merged
unmultimedio merged 1 commit intomainfrom
fetch-modules
Mar 25, 2025
Merged

Found new managed modules references#912
unmultimedio merged 1 commit intomainfrom
fetch-modules

Conversation

@app-token-modules
Copy link
Contributor

New managed modules references found. Please review.

@app-token-modules app-token-modules bot requested review from a team, euforic and stefanvanburen March 25, 2025 12:06
},
{
"name": "v0.22.1",
"digest": "1c306aa1b4ccd5968e233b36be7eb3e5ad94f819e6d6bb4232c9590792e3e85a6b90808c8b7c037fb4bc0c8535874ea67ad79b100c5d49b7848b25ea18c8db48"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

casdiff v0.22.0 v0.22.1 --format markdown

2 files changed: 0 removed, 0 renamed, 0 added, 2 changed content

Files changed content:

cel/expr/checked.proto:

--- shake256:86f511e907d336b0e3dd72c984d28e086f68841636305d269a1fe42f6a146ce6e7204fa203b0d342468172ca46ba927b4ee9f11147bd35c49d13e83e32807151  cel/expr/checked.proto
+++ shake256:4c748900447cb6d800a633a9025d9ddcb92cb359109df89743026c8cd160015f1b01a1ae3bd655b40bf27c48453b772c17aac592d15bbeb9ceefb2db8c25a442  cel/expr/checked.proto
@@ -236,6 +236,20 @@
     Constant value = 2;
 
     // Documentation string for the identifier.
+    //
+    // Provide a brief description of what the variable represents and whether
+    // there are any constraints on the formatting or supported value range.
+    //
+    // Examples:
+    //
+    //    'request.auth.principal' - string which uniquely identifies an
+    //    authenticated principal. For JSON Web Tokens (JWTs), the principal
+    //    is the combination of the issuer ('iss') and subject ('sub') token
+    //    fields concatenated by a forward slash: iss + `/` + sub.
+    //
+    //    'min_cpus' - integer value indicates the minimum number of CPUs
+    //    required for a compute cluster. The 'min_cpus' value must be 
+    //    greater than zero and less than 'max_cpus' or 64 whichever is less.
     string doc = 3;
   }
 
@@ -293,11 +307,45 @@
       bool is_instance_function = 5;
 
       // Documentation string for the overload.
+      //
+      // Provide examples of the overload behavior, preferring to use literal
+      // values as input with a comment on the return value.
+      //
+      // Examples:
+      //
+      //    // Determine whether a value of type <V> exists within a list<V>.
+      //    2 in [1, 2, 3] // returns true
+      //
+      //    // Determine whether a key of type <K> exists within a map<K,V>.
+      //    'hello' in {'hi': 'you', 'hello': 'there'}  // returns true
+      //    'help' in {'hi': 'you', 'hello': 'there'}  // returns false
+      //
+      //    // Take the substring of a string starting at a specific character
+      //    // offset (inclusive).
+      //    "tacocat".substring(1) // returns "acocat"
+      //    "tacocat".substring(20) // error
+      //
+      //    // Take the substring of a string starting at a specific character
+      //    // offset (inclusive) and ending at the given offset (exclusive).
+      //    "tacocat".substring(1, 6) // returns "acoca"
       string doc = 6;
     }
 
     // Required. List of function overloads, must contain at least one overload.
     repeated Overload overloads = 1;
+
+    // Documentation string for the function that indicates the general purpose
+    // of the function and its behavior.
+    //
+    // Documentation strings for the function should be general purpose with
+    // specific examples provided in the overload doc string.
+    //
+    // Examples:
+    // 
+    //     The 'in' operator tests whether an item exists in a collection.
+    //
+    //     The 'substring' function returns a substring of a target string.
+    string doc = 2;
   }
 
   // The fully qualified name of the declaration.

cel/expr/conformance/test/suite.proto:

--- shake256:8b6f33b30ae3d1b0cb1c06b1332e2205929d17a11239096fada8a4d64c204fad88d84adb5020b9a62a550e0b42b7cc63eb15e000b604d38577b4fbda015c59b0  cel/expr/conformance/test/suite.proto
+++ shake256:7170617f88d02351f25a4fcffa68279ec1fc60d349f417edcedd1af8c6eba3a867cdf457ce7cc8c5fd0278cc1d532c678bf0bf6abee44182c214b6539680c4ba  cel/expr/conformance/test/suite.proto
@@ -80,23 +80,65 @@
   cel.expr.conformance.Environment env = 4;
 
   // Input for the test case
+  TestInput input = 5;
+
+  // Expected result of the test case.
+  TestOutput output = 6;
+
+  // If specified validates that the deduced type at check time matches
+  // If the result kind is not set and this field is set, the test is considered
+  // "check-only".
+  cel.expr.Type deduced_type = 7;
+
+  // Bypass the type-checking and only attempt to evaluate the parsed
+  // expression.
+  bool disable_check = 8;
+}
+
+// Input for the test case
+message TestInput {
+  // The type of input for the test case
   oneof input_kind {
     // A set of variable bindings to be used for evaluating a checked
     // expression.
-    Bindings bindings = 5;
+    Bindings bindings = 1;
 
     // A context message represents an input kind in the form of a proto
     // message whose type is defined at runtime.
-    google.protobuf.Any context_message = 6;
+    google.protobuf.Any context_message = 2;
 
     // A context expression representing a context proto variable. The
     // fields of the input proto.Messages are used as top-level variables within
     // an Activation. The expression is evaluated using the cel environment
     // configured for the test suite.
-    string context_expr = 7;
+    string context_expr = 3;
   }
+}
 
-  // Expected result of the test case.
+// The bindings of input variables for the test case.
+message Bindings {
+  // A map representing a variable binding where the key is the name of the
+  // input variable.
+  map<string, InputValue> values = 1;
+}
+
+// The input value for a variable binding
+message InputValue {
+  // The type of input value that can be used for a variable binding
+  oneof kind {
+    // A simple literal value for a variable binding
+    cel.expr.Value value = 1;
+
+    // An expression which evaluates to the value of the variable binding.
+    // The expression is evaluated using the same runtime environment as the
+    // one used for evaluating the expression under test.
+    string expr = 2;
+  }
+}
+
+// Expected result of the test case.
+message TestOutput {
+  // Type of expected result of the test case.
   oneof result_kind {
     // A normal value, which must match the evaluation result exactly via value
     // equality semantics. This coincides with proto equality, except for:
@@ -116,20 +158,4 @@
     // An unknown evaluation result.
     cel.expr.UnknownSet unknown = 11;
   }
-
-  // If specified validates that the deduced type at check time matches
-  // If the result kind is not set and this field is set, the test is considered
-  // "check-only".
-  cel.expr.Type deduced_type = 12;
-
-  // Bypass the type-checking and only attempt to evaluate the parsed
-  // expression.
-  bool disable_check = 13;
 }
-
-// The bindings of input variables for the test case.
-message Bindings {
-  // A map representing a variable binding where the key is the name of the
-  // input variable.
-  map<string, cel.expr.Value> values = 1;
-}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking change but in test dir: cel/expr/conformance/test/*

The only other managed module dependent on this module is cncf/xds, but it doesn't import this file/dir.

SCR-20250325-jsrc

So all good.

@unmultimedio unmultimedio merged commit 7906802 into main Mar 25, 2025
5 checks passed
@unmultimedio unmultimedio deleted the fetch-modules branch March 25, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant