-
Notifications
You must be signed in to change notification settings - Fork 18
Add cmake support to protocolbuffers/cpp plugins to v25 #1577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
ab0acb5
Add cmake support retroactive to v25.0 and squash layers
ce1d9da
Whitespace
06efbdd
Patch 25.0-25.2 to ignore editions
5d0667e
Merge branch 'main' into sayers/cpp_to_25
smaye81 1e76052
Update to latest image
b86d1fd
Update to latest base image
c03363c
Bump the distroless group in /.github/docker with 6 updates (#1587)
dependabot[bot] 14db30e
Bump bazel-public/bazel from 7.4.0 to 7.4.1 in /.github/docker (#1589)
dependabot[bot] 704b1b6
Bump dotnet/sdk from 8.0.403-bookworm-slim to 8.0.404-bookworm-slim i…
dependabot[bot] 8151e01
Update protocolbuffers/go v1.35.2 (#1591)
app-token-plugins[bot] 1f253ee
Bump `protocolbuffers/[email protected]` to `netstandard2.0` (#1592)
saquibmian 1eb1b88
Bump github.com/bufbuild/buf from 1.46.0 to 1.47.2 (#1594)
dependabot[bot] 6f15a34
Update grpc to v1.68.0 (#1593)
app-token-plugins[bot] 4429a22
Update community/stephenh-ts-proto to v2.3.0 (#1595)
pkwarren 10ad6cd
Deprecate connectrpc/es and connectrpc/query-es (#1597)
mfridman c3d99d8
Add connectrpc/query-es v2.0.0 (#1598)
mfridman 3d91f23
Disable protoc-gen-connect-es updates (#1599)
mfridman 54d3f66
Bump github.com/stretchr/testify from 1.9.0 to 1.10.0 (#1601)
dependabot[bot] 2f49d4a
Update grpc-ecosystem plugins to v2.24.0 (#1602)
mfridman 905a24e
Disable protoc-gen-bq-schema sync (#1604)
mfridman a0a79d3
Add protoc-gen-bq-schema v2.0.1 (#1605)
mfridman a411150
Squash layers and update images
3546f75
Merge branch 'main' into sayers/cpp_to_25
304e1a7
Revert 26.1 plugins and squash layers/upgrade to Debian 12 in 25.0 pl…
c0c6eff
Bump additional base images
pkwarren File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| * | ||
| !BUILD | ||
| !cpp.cc | ||
| !disable_cpp_editions.patch | ||
| !Dockerfile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 20 additions & 0 deletions
20
plugins/protocolbuffers/cpp/v25.0/disable_cpp_editions.patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| diff --git a/src/google/protobuf/compiler/cpp/generator.h b/src/google/protobuf/compiler/cpp/generator.h | ||
| index 64f334d5b..fd6e08e84 100644 | ||
| --- a/src/google/protobuf/compiler/cpp/generator.h | ||
| +++ b/src/google/protobuf/compiler/cpp/generator.h | ||
| @@ -70,14 +70,7 @@ class PROTOC_EXPORT CppGenerator : public CodeGenerator { | ||
| std::string* error) const override; | ||
|
|
||
| uint64_t GetSupportedFeatures() const override { | ||
| - return FEATURE_PROTO3_OPTIONAL | FEATURE_SUPPORTS_EDITIONS; | ||
| - } | ||
| - | ||
| - Edition GetMinimumEdition() const override { return Edition::EDITION_PROTO2; } | ||
| - Edition GetMaximumEdition() const override { return Edition::EDITION_2023; } | ||
| - | ||
| - std::vector<const FieldDescriptor*> GetFeatureExtensions() const override { | ||
| - return {GetExtensionReflection(pb::cpp)}; | ||
| + return FEATURE_PROTO3_OPTIONAL; | ||
| } | ||
|
|
||
| private: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| * | ||
| !BUILD | ||
| !cpp.cc | ||
| !disable_cpp_editions.patch | ||
| !Dockerfile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 20 additions & 0 deletions
20
plugins/protocolbuffers/cpp/v25.1/disable_cpp_editions.patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| diff --git a/src/google/protobuf/compiler/cpp/generator.h b/src/google/protobuf/compiler/cpp/generator.h | ||
| index 64f334d5b..fd6e08e84 100644 | ||
| --- a/src/google/protobuf/compiler/cpp/generator.h | ||
| +++ b/src/google/protobuf/compiler/cpp/generator.h | ||
| @@ -70,14 +70,7 @@ class PROTOC_EXPORT CppGenerator : public CodeGenerator { | ||
| std::string* error) const override; | ||
|
|
||
| uint64_t GetSupportedFeatures() const override { | ||
| - return FEATURE_PROTO3_OPTIONAL | FEATURE_SUPPORTS_EDITIONS; | ||
| - } | ||
| - | ||
| - Edition GetMinimumEdition() const override { return Edition::EDITION_PROTO2; } | ||
| - Edition GetMaximumEdition() const override { return Edition::EDITION_2023; } | ||
| - | ||
| - std::vector<const FieldDescriptor*> GetFeatureExtensions() const override { | ||
| - return {GetExtensionReflection(pb::cpp)}; | ||
| + return FEATURE_PROTO3_OPTIONAL; | ||
| } | ||
|
|
||
| private: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| * | ||
| !BUILD | ||
| !cpp.cc | ||
| !disable_cpp_editions.patch | ||
| !Dockerfile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 20 additions & 0 deletions
20
plugins/protocolbuffers/cpp/v25.2/disable_cpp_editions.patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| diff --git a/src/google/protobuf/compiler/cpp/generator.h b/src/google/protobuf/compiler/cpp/generator.h | ||
| index 64f334d5b..fd6e08e84 100644 | ||
| --- a/src/google/protobuf/compiler/cpp/generator.h | ||
| +++ b/src/google/protobuf/compiler/cpp/generator.h | ||
| @@ -70,14 +70,7 @@ class PROTOC_EXPORT CppGenerator : public CodeGenerator { | ||
| std::string* error) const override; | ||
|
|
||
| uint64_t GetSupportedFeatures() const override { | ||
| - return FEATURE_PROTO3_OPTIONAL | FEATURE_SUPPORTS_EDITIONS; | ||
| - } | ||
| - | ||
| - Edition GetMinimumEdition() const override { return Edition::EDITION_PROTO2; } | ||
| - Edition GetMaximumEdition() const override { return Edition::EDITION_2023; } | ||
| - | ||
| - std::vector<const FieldDescriptor*> GetFeatureExtensions() const override { | ||
| - return {GetExtensionReflection(pb::cpp)}; | ||
| + return FEATURE_PROTO3_OPTIONAL; | ||
| } | ||
|
|
||
| private: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.