Change seq.Slice func field signatures to take an index#418
Merged
Conversation
mcy
changed the title
seq.Slice.Wrap by pointerseq.Slice.Wrap by pointer
jhump
approved these changes
Jan 10, 2025
jhump
changed the title
seq.Slice.Wrap by pointerseq.Slice.Wrap function signature to take a pointer
mcy
changed the title
seq.Slice.Wrap function signature to take a pointerseq.Slice func field signatures to take an index
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This slightly generalizes the API, since it allows
seq.Sliceusers to return values that reference the wrapped slice by pointer. This is not used in the AST package at the moment, but it will be useful for the IR package.