Conversation
mcy
force-pushed
the
mcy/suggestions-fix
branch
from
a8fe279 to
d414f97
Compare
jhump
reviewed
Jan 31, 2025
Member
jhump
left a comment
jhump
left a comment
There was a problem hiding this comment.
This seems to be largely, but not entirely, overlapping with changes in #431.
It's confusing to review since some of it I've already looked at. If it's not possible to cleanly separate the two, then please either hold off on one branch until the other is merged or set the base branch of one PR to point to the other (so it shows a diff from the other pending change).
doriable
approved these changes
Feb 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I discovered a few bugs in the suggestions rendering logic, which I've fixed in this PR. I've also included a reproducer test.