Skip to content

Expose non-primary spans from diagnostic #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
stefanvanburen wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Expose non-primary spans from diagnostic #659

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02017ab
Expose non-primary spans from diagnostic
stefanvanburen Jan 30, 2026
4035e3e
s/nonPrimary/relatedSpans
stefanvanburen Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions experimental/report/diagnostic.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,19 @@ func (d *Diagnostic) Primary() source.Span {
return source.Span{}
}

// RelatedSpans returns any spans related to this diagnostic that are not the primary span, if it has any.
// If it doesn't have any, it returns nil.
// (To get the primary span, use [Diagnostic.Primary].)
func (d *Diagnostic) RelatedSpans() []source.Span {
var relatedSpans []source.Span
for _, annotation := range d.snippets {
if !annotation.primary {
relatedSpans = append(relatedSpans, annotation.Span)
}
}
return relatedSpans
}

// Level returns this diagnostic's level.
func (d *Diagnostic) Level() Level {
return d.level
Expand Down
Loading