Skip to content

Add deprecated tag to diagnostics #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stefanvanburen merged 1 commit into from
Jan 30, 2026
Merged

Add deprecated tag to diagnostics #660

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions experimental/ir/lower_deprecated.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ package ir

import (
"github.com/bufbuild/protocompile/experimental/report"
"github.com/bufbuild/protocompile/experimental/report/tags"
"github.com/bufbuild/protocompile/experimental/seq"
"github.com/bufbuild/protocompile/experimental/source"
)
Expand Down Expand Up @@ -128,5 +129,6 @@ func (e errDeprecated) Diagnose(d *report.Diagnostic) {
report.Message("`%s` is deprecated", e.name),
report.Snippet(e.ref),
report.Snippetf(e.cause, "deprecated here"),
report.Tag(tags.Deprecated),
)
}
3 changes: 3 additions & 0 deletions experimental/report/tags/tags.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,4 +25,7 @@ const (
// in the current scope. This may indicate a missing import or a reference
// to a non-existent symbol.
UnknownSymbol = "protobuf:unknown_symbol"

// Deprecated is the tag for a diagnostic where a symbol is deprecated.
Deprecated = "protobuf:deprecated"
)
Loading