Enhance URI validation #257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 25 commits
April 1, 2025 10:57
smaye81
commented
Apr 3, 2025
| startsWith(), | ||
| endsWith(), | ||
| contains(), | ||
| celFormat(), |
Contributor
Author
There was a problem hiding this comment.
Renamed all these to stay consistent. I can un-rename them if it's confusing.
timostamm
reviewed
Apr 4, 2025
Member
timostamm
left a comment
timostamm
left a comment
There was a problem hiding this comment.
There's a new .DS_Store file that should be removed. The CI failure seems to be just a formatting issue.
added 2 commits
April 4, 2025 10:38
smaye81
pushed a commit
to bufbuild/protovalidate-python
that referenced
this pull request
Apr 4, 2025
- Avoid ambiguity in "string contains" - Don't quote identifiers with backticks - KISS with "Parses the rule" Context: bufbuild/protovalidate-java#257 (comment) Also see: bufbuild/protovalidate-go#208
timostamm
approved these changes
Apr 9, 2025
Member
timostamm
left a comment
timostamm
left a comment
There was a problem hiding this comment.
Renamed all these to stay consistent. I can un-rename them if it's confusing.
I'm not sure that names and organization are ideal, but I don't have an idea that's decisively better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ports the validation logic from protovalidate-go for validating URIs and URI references.