Skip to content

Implement structured field and rule paths for violations #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
8 commits merged into from
Nov 27, 2024
Merged

Implement structured field and rule paths for violations #217

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d1bf191
DO NOT MERGE: ypdate to experimental protovalidate
Nov 20, 2024
cfb7582
Implement structured field and rule paths for violations
Nov 21, 2024
e3bc41a
Update to pass latest conformance
Nov 25, 2024
47775ea
Merge branch 'main' of https://github.com/bufbuild/protovalidate-pyth…
Nov 25, 2024
069935c
Extract _field_path_string into internal
Nov 26, 2024
b9a59b5
Ignore missing mypy types on gencode
Nov 26, 2024
41f4521
Prefer absolute imports
Nov 27, 2024
32e7299
Update to protovalidate v0.9.0
Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ ADD_LICENSE_HEADER := $(BIN)/license-header \
--license-type apache \
--copyright-holder "Buf Technologies, Inc." \
--year-range "2023"
PROTOVALIDATE_VERSION ?= v0.8.2
# TODO: DO NOT MERGE
PROTOVALIDATE_VERSION ?= a4d7e113cc9e8944fb22098123eddc5413500381

.PHONY: help
help: ## Describe useful make targets
Expand All @@ -33,8 +34,10 @@ clean: ## Delete intermediate build artifacts
.PHONY: generate
generate: $(BIN)/buf $(BIN)/license-header ## Regenerate code and license headers
rm -rf gen
buf generate buf.build/bufbuild/protovalidate:$(PROTOVALIDATE_VERSION)
buf generate buf.build/bufbuild/protovalidate-testing:$(PROTOVALIDATE_VERSION)
# TODO: DO NOT MERGE
buf generate buf.build/jchadwick-buf/protovalidate:fd74cad4128d4294812fe3ad3fac0e2f
# TODO: DO NOT MERGE
buf generate buf.build/jchadwick-buf/protovalidate-testing:4b978585a3ae4589a2bf979580e0cf51
$(ADD_LICENSE_HEADER) --ignore __init__.py

.PHONY: format
Expand Down
30 changes: 16 additions & 14 deletions gen/buf/validate/conformance/cases/custom_constraints/custom_constraints_pb2.py
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions gen/buf/validate/conformance/cases/custom_constraints/custom_constraints_pb2.pyi
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 12 additions & 6 deletions gen/buf/validate/validate_pb2.py
View file
Open in desktop

Large diffs are not rendered by default.

38 changes: 36 additions & 2 deletions gen/buf/validate/validate_pb2.pyi
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading