Skip to content

Add URN validation #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 4, 2025
Merged

Add URN validation #248

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd9330a
Additional checks
Feb 4, 2025
030036c
Formatter
Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion protovalidate/internal/extra_func.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,8 +165,19 @@ def is_email(string: celtypes.Value) -> celpy.Result:

def is_uri(string: celtypes.Value) -> celpy.Result:
url = urlparse.urlparse(string)
if not all([url.scheme, url.netloc, url.path]):
# urlparse correctly reads the scheme from URNs but parses everything
# after (except the query string) as the path.
if url.scheme == "urn":
if not (url.path):
return celtypes.BoolType(False)
elif not all([url.scheme, url.netloc, url.path]):
return celtypes.BoolType(False)

# If the query string contains percent-encoding, then try to decode it.
# unquote will return the same string if it is improperly encoded.
if "%" in url.query:
return celtypes.BoolType(urlparse.unquote(url.query) != url.query)

return celtypes.BoolType(True)


Expand Down
Loading