Skip to content

Catch all exceptions in conformance runner.py #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025
Merged

Catch all exceptions in conformance runner.py #282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions tests/conformance/nonconforming.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,25 @@ standard_constraints/well_known_types/duration:
standard_constraints/well_known_types/timestamp:
- gte_lte/invalid/above
- lte/invalid

library/is_ip:
- version/omitted/invalid/ipv6/g
# input: [type.googleapis.com/buf.validate.conformance.cases.IsIp]:{val:":0::0"}
# want: validation error (1 violation)
# 1. constraint_id: "library.is_ip"
# got: valid
- version/omitted/invalid/ipv6/h
# input: [type.googleapis.com/buf.validate.conformance.cases.IsIp]:{val:"0::0:"}
# want: validation error (1 violation)
# 1. constraint_id: "library.is_ip"
# got: valid
- version/omitted/invalid/ipv6/i
# input: [type.googleapis.com/buf.validate.conformance.cases.IsIp]:{val:"0::0:"}
# want: validation error (1 violation)
# 1. constraint_id: "library.is_ip"
# got: valid
- version/omitted/invalid/ipv6/j
# input: [type.googleapis.com/buf.validate.conformance.cases.IsIp]:{val:"::0000ffff"}
# want: validation error (1 violation)
# 1. constraint_id: "library.is_ip"
# got: unexpected error: string index out of range
2 changes: 2 additions & 0 deletions tests/conformance/runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,8 @@ def run_test_case(tc: typing.Any, result: typing.Optional[harness_pb2.TestResult
result.runtime_error = str(e)
except protovalidate.CompilationError as e:
result.compilation_error = str(e)
except Exception as e:
result.unexpected_error = str(e)
return result


Expand Down
Loading