Regenerate code and some cleanups to cel funcs #284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update generated code to match runtime requirement (6.30.1). Make some small fixes to custom CEL functions.
pkwarren
commented
Apr 15, 2025
| enabled: true | ||
| plugins: | ||
| - remote: buf.build/protocolbuffers/python:v29.3 | ||
| - remote: buf.build/protocolbuffers/python:v30.1 |
Member
Author
There was a problem hiding this comment.
Saw warnings when running the tests that the generated code version didn't match the runtime version. Upgraded it to match here.
| start = self._index | ||
|
|
||
| while True: | ||
| if self._index >= len(self._string) or not self.__digit(): |
Member
Author
There was a problem hiding this comment.
Noticed this pattern in a few places - I think it is better to lift the condition into the while statement if possible. We were doing this already in a few places in the URI parsing but not here.
smaye81
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update generated code to match runtime requirement (6.30.1). Make some small fixes to custom CEL functions.