Fix various v0.11.0 conformance issues #294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We still have the nanosecond granularity issues that we've always had, but this should fix everything else.
ghost
marked this pull request as ready for review
ghost
enabled auto-merge (squash)
smaye81
reviewed
Apr 28, 2025
protovalidate/internal/extra_func.py
Outdated
| # Handle double colon, fill pieces with 0 | ||
| if self._double_colon_seen: | ||
| if len(p16) >= 7: | ||
| return 0 |
Author
There was a problem hiding this comment.
This is because get_bits is supposed to return 0 if the address is invalid.
def get_bits(self) -> int:
"""Return the 128-bit value of an address parsed through address() or address_prefix().
Return 0 if no address was parsed successfully.
"""OTOH, though, it doesn't really matter, so I removed it.
smaye81
approved these changes
Apr 29, 2025
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We still have the nanosecond granularity issues that we've always had, but this should fix everything else.