Skip to content

Simplify isinstance call in extra_func.py #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 25, 2025
Merged

Simplify isinstance call in extra_func.py #357

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
899f1e7
Simplify `isinstance` call in `extra_func.py`
engnatha Aug 25, 2025
a6f51a4
Merge branch 'main' into main
engnatha Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion protovalidate/internal/extra_func.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,7 @@ def cel_is_inf(val: celtypes.Value, sign: typing.Optional[celtypes.Value] = None


def cel_unique(val: celtypes.Value) -> celpy.Result:
if not isinstance(val, celtypes.ListType) and not isinstance(val, list):
if not isinstance(val, (celtypes.ListType, list)):
msg = "invalid argument, expected list"
raise celpy.CELEvalError(msg)
return celtypes.BoolType(len(val) == len(set(val)))
Expand Down