Add support for cel expressions to scalar types #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alfus
changed the title
bufdev
requested changes
Apr 25, 2025
Member
bufdev
left a comment
bufdev
left a comment
There was a problem hiding this comment.
This is surprising behavior for a yaml library, and not something I'd expect to automatically occur. If we were to add this down the road, it would need extensive documentation including in readme, package docs, and API, explaining how this works, and the need for it.
Overall, I'd expect to be able to fuzz protojson against protoyaml and see no difference in behavior.
| // returning an error. | ||
| DiscardUnknown bool | ||
|
|
||
| // CelEnv is the CEL environment to use for evaluating CEL expressions. |
Member
There was a problem hiding this comment.
Would need more documentation: why is this here, what is it for, why is it part of a yaml library
Contributor
Author
|
protoyaml is not protojson and you cannot fuzz them like that for many reason. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since protoyaml depends on protovalidate, cel-go is already a dependency.
Scalars that do not trivially parse are passed through cel to see if they can be evaluated.
The tag
!celcan be used to force cel evaluation for strings.Similar to protovalidate,
thisandnoware bound.