Skip to content

Improve Windows support #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1 commit merged into from
Jul 24, 2025
Merged

Improve Windows support #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
85 changes: 82 additions & 3 deletions MODULE.bazel.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 9 additions & 3 deletions buf/internal/toolchain.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ declare_buf_toolchains(
"""

_TOOLCHAIN_FILE = """
load("@bazel_skylib//rules:native_binary.bzl", "native_binary")

def _buf_toolchain_impl(ctx):
toolchain_info = platform_common.ToolchainInfo(
cli = ctx.executable.cli,
Expand All @@ -52,13 +54,15 @@ _buf_toolchain = rule(

def declare_buf_toolchains(os, cpu, rules_buf_repo_name):
for cmd in ["buf", "protoc-gen-buf-lint", "protoc-gen-buf-breaking"]:
cmd_suffix = ""
if os == "windows":
cmd_suffix = ".exe"
native_binary(
name = cmd,
src = ":" + cmd + ".exe",
)
toolchain_impl = cmd + "_toolchain_impl"
_buf_toolchain(
name = toolchain_impl,
cli = str(Label("//:"+ cmd + cmd_suffix)),
cli = str(Label("//:"+ cmd)),
)
native.toolchain(
name = cmd + "_toolchain",
Expand Down Expand Up @@ -138,6 +142,8 @@ def _buf_download_releases_impl(ctx):
for sha_line in sha_list:
if sha_line.strip(" ").endswith(".tar.gz"):
continue
if sha_line.strip(" ").endswith(".zip"):
continue
(sum, _, bin) = sha_line.partition(" ")
bin = bin.strip(" ")
lower_case_bin = bin.lower()
Expand Down
Loading