feat: add PyPI/Python support (deps-pypi crate)#15
Merged
Conversation
- Add deps-pypi crate with PEP 621 and Poetry pyproject.toml parsing - Implement PyPI registry client with HTTP caching - Add codecov badges to all crate READMEs
github-actions
bot
added
documentation
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
Implement deps_core trait integration: - Add ManifestParser trait implementation for PypiParser - Add DependencyInfo trait implementation for PypiDependency - Add ParseResultInfo trait for ParseResult - Introduce ParseResult type for parser output Fix is_prerelease() false positives: - Replace string scanning with pep440_rs::Version::is_pre() - Eliminates false positives from packages like "stable" - Uses proper PEP 440 prerelease detection Add PEP 503 package name normalization: - Implement normalize_package_name() function - Converts to lowercase, replaces underscores/dots with hyphens - Ensures consistent PyPI lookups for "Flask" vs "flask" - Apply normalization in get_versions() and get_package_metadata() Optimize version sorting: - Parse versions once before sorting instead of twice per comparison - Cache parsed Version objects during sort operation - Reduces parsing overhead by ~50% for typical package version lists Update license allowlist: - Add MPL-2.0 to deny.toml for version-ranges dependency All tests passing (23/23). Clippy clean with -D warnings.
Fixed doctests that were using the trait method parse() incorrectly. Changed to use parse_content() method directly which is the public API. All other code review items were already implemented: - ManifestParser, DependencyInfo, ParseResultInfo traits - is_prerelease() using pep440_rs - normalize_package_name() function - Version sorting optimization - MPL-2.0 license in deny.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add Python/PyPI ecosystem support via new
deps-pypicrate.New Features
[project.dependencies]and[project.optional-dependencies][tool.poetry.dependencies]and[tool.poetry.group.*.dependencies]Documentation
Files Added
crates/deps-pypi/- New crate with parser, registry, types, error handlingReference
Based on zed-dependi implementation patterns.