Skip to content

fix(npm): remove extra quotes in code action version replacements #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bug-ops merged 2 commits into from
Dec 24, 2025
Merged

fix(npm): remove extra quotes in code action version replacements #29

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d012ce
fix(npm): remove extra quotes in code action version replacements
bug-ops Dec 24, 2025
54a6042
style: fix formatting in npm formatter tests
bug-ops Dec 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions crates/deps-npm/src/formatter.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@ pub struct NpmFormatter;

impl EcosystemFormatter for NpmFormatter {
fn format_version_for_code_action(&self, version: &str) -> String {
format!("\"{}\"", version)
// Don't add quotes - version_range already excludes them from parser
version.to_string()
}

fn package_url(&self, name: &str) -> String {
Expand Down Expand Up @@ -41,14 +42,12 @@ mod tests {
#[test]
fn test_format_version() {
let formatter = NpmFormatter;
// Version should not include quotes - parser's version_range excludes them
assert_eq!(
formatter.format_version_for_code_action("1.0.214"),
"\"1.0.214\""
);
assert_eq!(
formatter.format_version_for_code_action("18.3.1"),
"\"18.3.1\""
"1.0.214"
);
assert_eq!(formatter.format_version_for_code_action("18.3.1"), "18.3.1");
}

#[test]
Expand Down
Loading