Conversation
…ck file ResolvedPackages now stores all versions per package name and returns the highest semver version through public API. Fixes incorrect outdated status when both direct and transitive dependency versions coexist in the lock file.
github-actions
bot
added
rust
github-actions
bot
added
the
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ResolvedPackagesnow stores all versions per package name internally (HashMap<String, Vec<ResolvedPackage>>)get(),get_version(),iter(),into_map()return the highest semver versionbest_package()helper with semver comparison and string fallback for non-semver versionsget_all()method to access all stored versionsFixes incorrect outdated status when both direct and transitive dependency versions of the same package coexist in the lock file. Affects all ecosystems (cargo, npm, pypi, go, bundler).
Test plan
cargo nextest run -p deps-core(203 tests pass)cargo nextest run --workspace(977 tests pass)cargo clippy --workspace -- -D warningsclean