Conversation
…emove once_cell Consolidate complete_package_names across Cargo, npm, PyPI, Bundler, Dart ecosystems to use complete_package_names_generic from deps-core. Rename ranges_overlap to position_in_range for semantic clarity. Replace once_cell::sync::Lazy with std::sync::LazyLock, remove once_cell dependency. Seal Ecosystem trait with private::Sealed supertrait to prevent external implementations. Rename format_version_for_code_action to format_version_for_text_edit to better reflect its TextEdit context. Closes #68
github-actions
bot
added
rust
Closed
22 tasks
Consolidate 4 duplicate DependencySource enums (Cargo, PyPI, Dart, Bundler) into a single 7-variant enum in deps-core: Registry, Git, Path, Url, Sdk, Workspace, CustomRegistry. Eliminates lossy conversions at trait boundaries: PyPI Url and Dart Sdk variants are now preserved through the Dependency trait. Cargo workspace_inherited bool replaced by DependencySource::Workspace. Add #[non_exhaustive] for forward compatibility. Add is_registry() and is_version_resolvable() convenience methods. Simplify UnifiedDependency::is_registry() to delegate to core enum. Ref #68
github-actions
bot
added
parser
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remaining cleanup items from #68:
complete_package_namesacross 5 ecosystems (Cargo, npm, PyPI, Bundler, Dart) to usecomplete_package_names_genericranges_overlap→position_in_rangefor semantic clarityonce_cell::sync::Lazywithstd::sync::LazyLock, removeonce_celldependencyEcosystemtrait withprivate::Sealedsupertraitformat_version_for_code_action→format_version_for_text_editCloses #68
Test plan
cargo +nightly fmt --checkcargo clippy --workspace --all-targets --all-features -- -D warningscargo nextest run --workspace --lib --bins(1106 passed)ranges_overlap,format_version_for_code_action,once_cell)