feat: Phase 5.1 - HTTP bindings and Podcast 2.0 support #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTTP Bindings: - Add parse_url() and parse_url_with_limits() to Python bindings - Add parseUrl() and parseUrlWithOptions() to Node.js bindings - Support conditional GET with ETag/Last-Modified headers - Expose HTTP metadata (status, href, etag, modified, headers) - Enable http feature flag (default) for both bindings Podcast 2.0 Support: - Add podcast_transcripts and podcast_persons to Entry struct - Parse podcast:transcript elements with url, type, language, rel - Parse podcast:person elements with name, role, group, img, href - Expose podcast fields in Python and Node.js Entry types iTunes Improvements: - Fix subcategory parsing with proper nested category handling - Support both flat and nested iTunes category structures All 315 tests pass, zero clippy warnings.
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (19.42%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. @@ Coverage Diff @@
## main #12 +/- ##
==========================================
- Coverage 81.18% 78.80% -2.38%
==========================================
Files 27 27
Lines 4145 4303 +158
==========================================
+ Hits 3365 3391 +26
- Misses 780 912 +132
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Security (PRIORITY 1): - Add 512-byte length limit for User-Agent header - Add 1KB length limit for ETag header - Add 64-byte length limit for Last-Modified header - Prevents header injection and DoS attacks Performance (PRIORITY 2): - Pre-allocate HashMap for HTTP response headers - Add Vec::with_capacity() for Node.js Entry conversion - Update Entry::with_capacity() defaults for podcasts: - podcast_transcripts: 2 (was 1) - podcast_persons: 4 (was 2) Code quality (PRIORITY 3): - Add limit_string() helper function in RSS parser - Replace 4 occurrences of chars().take().collect() pattern - Better byte-length check before char iteration All 315 tests pass, zero clippy warnings.
Owner
Author
Review Fixes Applied ✅All issues from the 4 review agents have been addressed: Security (PRIORITY 1)
Performance (PRIORITY 2)
Code Quality (PRIORITY 3)
Verification:
|
Node.js native test runner uses --experimental-test-coverage flag, not --coverage. Add test:coverage script and update CI workflow.
Node.js native test runner outputs coverage to console only. Use c8 to generate lcov reports for codecov upload. - Add [email protected] as dev dependency - Update test:coverage script to use c8 with lcov reporter - Output coverage files to ./coverage directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements Phase 5.1 of the feedparser-rs roadmap:
HTTP Bindings
parse_url()andparse_url_with_limits()functions for fetching feeds via HTTPparseUrl()andparseUrlWithOptions()functions for fetching feeds via HTTPETagandLast-Modifiedheaders for efficient pollingstatus,href,etag,modified,headershttp(enabled by default) for conditional compilationPodcast 2.0 Support
podcast_transcriptsandpodcast_personsfields to Entry struct<podcast:transcript>elements with attributes: url, type, language, rel<podcast:person>elements with attributes: name (text), role, group, img, hrefiTunes Improvements
<itunes:category>structuresChanges
feedparser-rs-py/Cargo.tomlhttpfeature flagfeedparser-rs-py/src/lib.rsparse_url(),parse_url_with_limits()feedparser-rs-py/src/types/parsed_feed.rsfeedparser-rs-py/src/types/entry.rsfeedparser-rs-node/Cargo.tomlhttpfeature flagfeedparser-rs-node/src/lib.rsparseUrl(),parseUrlWithOptions(), podcast typesfeedparser-rs-core/src/types/entry.rspodcast_transcripts,podcast_personsfeedparser-rs-core/src/parser/rss.rsTest plan