fix(memory,core): eliminate Qdrant upsert timing race and add RuntimeLayer tests#2430
Merged
fix(memory,core): eliminate Qdrant upsert timing race and add RuntimeLayer tests#2430
Conversation
…Layer tests (#2413, #2361) - use wait=true on QdrantOps::upsert to block until points are indexed, eliminating scroll_all race in document_integration tests (#2413) - add multi_layer_before_after_tool_ordering test to RuntimeLayer (#2361) - fix float comparison in confusability threshold test (clippy::float_cmp)
github-actions
bot
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wait(false)→wait(true)inQdrantOps::upsertso upsert blocks until Qdrant has indexed points, eliminating thescroll_alltiming race indocument_integrationtestsmulti_layer_before_after_tool_orderingtest toRuntimeLayer; the other two tests from the issue were already presentclippy::float_cmpin confusability threshold test (builder.rs)Test plan
cargo +nightly fmt --check— cleancargo clippy --features full --workspace -- -D warnings— cleancargo nextest run --features full --workspace --lib --bins— 7266 passed (+1)Closes #2413
Closes #2361