Conversation
…ion control (#2433, #2432, #2416) Implement three research-driven memory improvements: ACON (#2433): add per-category compression guidelines (tool_output, assistant_reasoning, user_context) with lazy per-category guideline updates to avoid 3x LLM cost. New `category` column on compression_failure_pairs and compression_guidelines tables (migration 054); UNIQUE(version, category) replaces UNIQUE(version). Memex (#2432): archive tool output bodies to SQLite before compaction via `save_archive()` with `archive_type='archive'`; inject UUID references as postfix after LLM summarization so placeholders survive compaction; cleanup_overflow() skips archive rows. Opt-in via `[memory.compression] archive_tool_outputs = true`. RL admission (#2416): add AdmissionStrategy enum (heuristic/rl) and admission_training_data + admission_rl_weights tables (migration 055); record all messages (admitted + rejected) to fix survivorship bias; pure-Rust logistic regression with 50-epoch mini-batch GD; mark_training_recalled() wires positive labels from SemanticMemory::recall(); startup warn when rl strategy is configured but not yet wired into live admission path.
d2e5fb9 to
021e481
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements three P2 research-driven memory improvements:
[memory.compression] archive_tool_outputs = falsetool_output,assistant_reasoning,user_context); lazy per-category guideline updates to avoid 3x LLM overhead; opt-in viacategorized_guidelines = trueAdmissionStrategyenum (heuristic|rl); records all messages (admitted + rejected) to eliminate survivorship bias; pure-Rust logistic regression (50-epoch mini-batch GD);was_recalledwired fromSemanticMemory::recall()for positive labels; startup warn whenrlis configured (data layer complete; live prediction wired in follow-up)Architecture notes
archive_typecolumn ontool_overflow; cleanup skips archivesMigrations
054_memex_and_acon_categories.sql—archive_typeontool_overflow,categoryoncompression_failure_pairs/compression_guidelines, updated UNIQUE constraints055_admission_training_data.sql—admission_training_data,admission_rl_weightstablesTest plan
cargo nextest run --workspace --features full --lib --bins)cargo +nightly fmt --checkpassescargo clippy --all-targets --features full --workspace -- -D warningspassesclassify_failure_category()(tool_output, assistant_reasoning, user_context, priority ordering)Closes #2433
Closes #2432
Closes #2416