feat(acp): expose current model in SessionInfoUpdate and session/list (#2435)#2453
Merged
feat(acp): expose current model in SessionInfoUpdate and session/list (#2435)#2453
Conversation
…#2435) Each in-memory SessionInfo in session/list now carries meta.currentModel. After session/set_config_option with configId=model, a SessionInfoUpdate notification is sent with meta.currentModel in addition to the existing ConfigOptionUpdate. Same notification is emitted after set_session_model.
github-actions
bot
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SessionInfoinsession/listnow carriesmeta.currentModelsession/set_config_optionwithconfigId=model, aSessionInfoUpdatenotification is streamed withmeta.currentModel(in addition to the existingConfigOptionUpdate)session/set_session_model, the sameSessionInfoUpdatenotification is emittedmodel_meta(model: &str) -> Metainhelpers.rsbuilds the{"currentModel": "..."}maplist_sessions_includes_model_meta,set_config_option_model_emits_session_info_updateTest plan
cargo +nightly fmt --check— cleancargo clippy --all-targets --features full --workspace -- -D warnings— cleancargo nextest run --workspace --features full --lib --bins— 7319 passed, 0 failedCloses #2435