feat(tools): add max_snapshot_bytes limit to transactional ShellExecutor#2476
Merged
feat(tools): add max_snapshot_bytes limit to transactional ShellExecutor#2476
Conversation
Add `max_snapshot_bytes: u64` to `ShellConfig` (default 0 = unlimited). `TransactionSnapshot::capture()` now tracks cumulative bytes and aborts with `ToolError::SnapshotFailed` if the configured limit is exceeded, preventing disk exhaustion from unbounded snapshot copies. Closes #2474
github-actions
bot
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
max_snapshot_bytes: u64toShellConfig(default0= unlimited)TransactionSnapshot::capture()accumulates byte count per file and aborts withToolError::SnapshotFailedwhen the limit is exceededTest plan
cargo nextest run -p zeph-tools --lib— 922 tests passcargo +nightly fmt --check— cleancargo clippy -p zeph-tools --all-features -- -D warnings— cleanCloses #2474