Conversation
github-actions
bot
added
documentation
…l path (#2484, #2483) HeuristicRouter, LlmRouter, or HybridRouter based on strategy. Router is stored as Box<dyn AsyncMemoryRouter> and recall_routed_async() is called so LLM-based classification actually fires instead of silently degrading to heuristic. routing_classifier_provider is resolved from provider_pool at config-apply time using the existing resolve_background_provider pattern. passes it to remember() and remember_with_parts() enabling goal-conditioned write gating in A-MAC admission control. All test call sites updated with None. Zero behavior change when goal_conditioned_write = false. Breaking: RoutingConfig and RoutingStrategy removed; use StoreRoutingConfig and [memory.store_routing] instead.
bug-ops
force-pushed
the
wire-memory-routing-goal-text
branch
from
314247e to
f7efe20
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StoreRoutingConfigintobuild_router()sostrategy = llm|hybridactually invokes LLM-based classification viarecall_routed_async()(closes feat(memory): wire StoreRoutingConfig into build_router() for cost-sensitive routing #2484)goal_textfrom raw user input intoremember()/remember_with_parts()so goal-conditioned write gating activates whengoal_conditioned_write = true(closes feat(memory): wire goal_text from agent context into remember() calls for CraniMem write gate #2483)RoutingConfig/RoutingStrategyfromzeph-config(superseded byStoreRoutingConfig/StoreRoutingStrategy)Changes
#2484 — build_router() dispatch:
build_router()returnsBox<dyn AsyncMemoryRouter + Send + Sync>and dispatches onstore_routing.strategyresolve_background_provider()at config-apply timefetch_semantic_recallnow callsrecall_routed_async()— LLM classifier actually firesAsyncMemoryRouterimpl added forHeuristicRouterandHybridRouterparse_route_strmadepub; oldRoutingConfig/RoutingStrategyremoved#2483 — goal_text wiring:
MemoryState.goal_text: Option<String>set from raw user input before firstpersist_messageremember()/remember_with_parts()extended withgoal_text: Option<&str>goal_textviapersist_messagegoal_conditioned_write = falseBreaking change
[memory.routing]TOML section no longer recognised — use[memory.store_routing]instead.RoutingConfig/RoutingStrategytypes removed fromzeph-config.Checks
cargo +nightly fmt --check✅cargo clippy --workspace --features full -- -D warnings✅cargo nextest run --features full✅ — 7564/7564 passed