Conversation
github-actions
bot
added
refactor
…Provider ModelOrchestrator and its orchestrator/ module were never instantiated at runtime. LlmRoutingStrategy::Task was a stub that fell through to a single provider. All real routing uses RouterProvider (EMA/Thompson/Cascade/Bandit) and TriageRouter, which are strictly more capable. Remove: - crates/zeph-llm/src/orchestrator/ (mod.rs, classifier.rs, router.rs, ~2700 lines) - AnyProvider::Orchestrator variant and all match arms - orchestrator_* fields and wizard choice from init.rs - Dead branches in bootstrap/mod.rs, bootstrap/health.rs, guardrail.rs Keep: - chat_with_named_provider / chat_with_named_provider_and_tools (external callers) - migrate.rs "orchestrator" branch (backward compat for legacy configs) Fixes #2540
bug-ops
force-pushed
the
feat/issue-2540/remove-dead-orchestrator
branch
from
f83a82d to
e331447
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2540
Summary
crates/zeph-llm/src/orchestrator/(~2700 lines:ModelOrchestrator,SubProvider,TaskType,ModelSelection)AnyProvider::Orchestratorvariant and all match arms (any.rs,health.rs,bootstrap/mod.rs,guardrail.rs)orchestrator_*wizard fields and "Orchestrator (multi-model)" choice fromsrc/init.rschat_with_named_provider/chat_with_named_provider_and_tools— removed Orchestrator special-case, kept delegating fallback (external callers preserved)ibct.rsand single-armmatch → if letinguardrail.rs/health.rsmigrate.rs"orchestrator" branch is intentionally kept for backward-compatible config migration.Test plan
cargo +nightly fmt --check— passcargo clippy --features full --workspace -- -D warnings— pass, zero warningscargo nextest run --features full --workspace --lib --bins— 7573/7573 passedgrep -r "ModelOrchestrator\|AnyProvider::Orchestrator"— zero results