fix: vscode link to editor #244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds VSCode-specific link formatting for opening files in the editor. VSCode uses a different URL scheme (vscode://file/path:line) compared to other editors like PHPStorm which use query parameters.
Key Changes
- Added conditional logic to detect when VSCode is the configured editor and generate the appropriate URL format
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| return '' | ||
| } | ||
|
|
||
| if (codeEditor.value == 'vscode') { |
There was a problem hiding this comment.
Use strict equality operator (===) instead of loose equality (==) for comparison. TypeScript/JavaScript best practices recommend using === to avoid unexpected type coercion issues.
Suggested change
| if (codeEditor.value == 'vscode') { | |
| if (codeEditor.value === 'vscode') { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
A vscode-specific link to open the file in the editor was added
Why?
vscode uses a different format to phpstorm for the link to the file, for vscode:// links
Checklist
** Untested as I can't get the local development working on my computer, but I'm 99% sure it's good!