Fix WS frame packing for large packets #202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… byte order
This commit improves WebSocket protocol support for large packets by fixing
the byte order encoding for 64-bit payload lengths according to RFC 6455.
Changes:
- Frame.php: Changed from pack('CJ') to pack('CNN') to encode 64-bit length
as two 32-bit integers in network byte order (big-endian)
- StreamReader.php: Changed from unpack('J') to unpack('N2') to decode
64-bit length in network byte order
- Added comprehensive test suite for different payload sizes (small <126,
medium 126-65535, large 65536+ bytes)
The previous implementation used machine-dependent byte order ('J' format),
which could fail on little-endian systems. The new implementation correctly
uses network byte order as required by the WebSocket specification.
All tests pass: 24 tests with 93 assertions.
roxblnfk
deleted the
claude/websocket-large-packets-018m1atQb2aXa9t5vZwGPMAC
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Fixed WebSocket protocol support for large packets by correcting byte order encoding for 64-bit payload lengths:
pack('CJ')topack('CNN')to encode 64-bit length as two 32-bit integers in network byte order (big-endian)unpack('J')tounpack('N2')to decode 64-bit length in network byte orderWhy?
The previous implementation used the
'J'format inpack()/unpack(), which uses machine-dependent byte order. This could cause failures on little-endian systems when handling WebSocket frames with payloads larger than 65535 bytes.According to RFC 6455 Section 5.2, multibyte length quantities must be expressed in network byte order (big-endian). The fix ensures cross-platform compatibility by properly packing/unpacking 64-bit lengths as two 32-bit integers in network byte order.
Checklist
Generated with ❤️ by Claude Code