Skip to content

Fix extreme compares with "relaxed" versions #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmaglie merged 3 commits into from
Feb 14, 2025
Merged

Fix extreme compares with "relaxed" versions #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
157e743
Added unit-tests
cmaglie Feb 14, 2025
c7b2412
Fixed some relaxed compare cases
cmaglie Feb 14, 2025
8328806
Updated codecov action
cmaglie Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,9 @@ jobs:
- name: Run unit tests with coverage
run: go test -v -race -covermode=atomic -coverprofile=coverage.out ./...
shell: bash
- uses: codecov/codecov-action@v2
- uses: codecov/codecov-action@v5
with:
verbose: true
env:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}

8 changes: 4 additions & 4 deletions version.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,9 +133,9 @@ func (v *Version) CompareTo(u *Version) int {
return -1
}
} else if vMajor == 0 && u.bytes[uIdx] == '0' {
return 0
// continue
} else if uMajor == 0 && v.bytes[vIdx] == '0' {
return 0
// continue
} else if vMajor > uMajor {
return 1
} else {
Expand All @@ -162,9 +162,9 @@ func (v *Version) CompareTo(u *Version) int {
return -1
}
} else if vMinor == vMajor && u.bytes[uIdx] == '0' {
return 0
// continue
} else if uMinor == uMajor && v.bytes[vIdx] == '0' {
return 0
// continue
} else if la > lb {
return 1
} else {
Expand Down
12 changes: 12 additions & 0 deletions version_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,19 @@ func TestVersionComparator(t *testing.T) {
}
}
}
ascending(t, false, "", "0.0.1")
ascending(t, false, "", "0.1")
ascending(t, false, "", "1")
ascending(t, false, "0", "0.0.1")
ascending(t, false, "0", "0.1")
ascending(t, false, "0", "1")
ascending(t, false, "0.0", "0.0.1")
ascending(t, false, "0.0", "0.1")
ascending(t, false, "0.0", "1")
ascending(t, false,
"",
"0.0.1",
"0.1",
"1.0.0-2",
"1.0.0-11",
"1.0.0-11a",
Expand Down