Skip to content

Fix extreme compares with "relaxed" versions#20

Merged
cmaglie merged 3 commits intomasterfrom
fix_extreme_compares
Feb 14, 2025
Merged

Fix extreme compares with "relaxed" versions#20
cmaglie merged 3 commits intomasterfrom
fix_extreme_compares

Conversation

@cmaglie
Copy link
Member

@cmaglie cmaglie commented Feb 14, 2025

Fixed the CompareTo method in some extreme cases:

"" < "0.0.1"
"0" < "0.0.1"
"0.0" < "0.0.1"

@cmaglie cmaglie self-assigned this Feb 14, 2025
@cmaglie cmaglie added the bug Something isn't working label Feb 14, 2025
@codecov
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b4bf3c6) to head (8328806).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #20   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines         1033      1033           
=========================================
  Hits          1033      1033           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmaglie cmaglie merged commit 6ae0217 into master Feb 14, 2025
5 checks passed
@cmaglie cmaglie deleted the fix_extreme_compares branch February 14, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant