Skip to content

Correct typo in names of "IsPrerelease" methods #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmaglie merged 1 commit into from
Mar 26, 2025
Merged

Correct typo in names of "IsPrerelease" methods #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions relaxed_version.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,13 +119,13 @@ func (v *RelaxedVersion) SortableString() string {
return ":" + string(v.customversion)
}

// IsPrerelase returns true if the version is valid semver and has a pre-release part
// IsPrerelease returns true if the version is valid semver and has a pre-release part
// otherwise it returns false.
func (v *RelaxedVersion) IsPrerelase() bool {
func (v *RelaxedVersion) IsPrerelease() bool {
if v.version == nil {
return false
}
return v.version.IsPrerelase()
return v.version.IsPrerelease()
}

// Prerelease returns the pre-release part of the version if the version is valid semver
Expand Down
6 changes: 3 additions & 3 deletions version.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,14 +495,14 @@ func (v *Version) SortableString() string {
return res
}

// IsPrerelase returns true if the version has a pre-release part
func (v *Version) IsPrerelase() bool {
// IsPrerelease returns true if the version has a pre-release part
func (v *Version) IsPrerelease() bool {
return v.prerelease != v.patch
}

// Prerelease returns the pre-release part of the version
func (v *Version) Prerelease() string {
if !v.IsPrerelase() {
if !v.IsPrerelease() {
return ""
}
return v.raw[v.patch+1 : v.prerelease]
Expand Down
6 changes: 3 additions & 3 deletions version_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,13 +333,13 @@ func TestVersionGetters(t *testing.T) {
for _, tt := range tests {
v := MustParse(tt.version)
require.Equal(t, tt.version, v.String())
require.Equal(t, tt.prerelease != "", v.IsPrerelase())
require.Equal(t, tt.prerelease != "", v.IsPrerelease())
require.Equal(t, tt.prerelease, v.Prerelease())
require.Equal(t, tt.build != "", v.HasBuildMetadata())
require.Equal(t, tt.build, v.BuildMetadata())
r := ParseRelaxed(tt.version)
require.Equal(t, tt.version, r.String())
require.Equal(t, tt.prerelease != "", r.IsPrerelase())
require.Equal(t, tt.prerelease != "", r.IsPrerelease())
require.Equal(t, tt.prerelease, r.Prerelease())
require.Equal(t, tt.build != "", r.HasBuildMetadata())
require.Equal(t, tt.build, r.BuildMetadata())
Expand All @@ -355,7 +355,7 @@ func TestVersionGetters(t *testing.T) {
require.Nil(t, v)
r := ParseRelaxed(tt.version)
require.Equal(t, tt.version, r.String())
require.Equal(t, tt.prerelease != "", r.IsPrerelase())
require.Equal(t, tt.prerelease != "", r.IsPrerelease())
require.Equal(t, tt.prerelease, r.Prerelease())
require.Equal(t, tt.build != "", r.HasBuildMetadata())
require.Equal(t, tt.build, r.BuildMetadata())
Expand Down