Skip to content

Correct typo in names of "IsPrerelease" methods#27

Merged
cmaglie merged 1 commit intobugst:masterfrom
per1234:fix-method-name-typo
Mar 26, 2025
Merged

Correct typo in names of "IsPrerelease" methods#27
cmaglie merged 1 commit intobugst:masterfrom
per1234:fix-method-name-typo

Conversation

@per1234
Copy link
Collaborator

@per1234 per1234 commented Mar 21, 2025

Previously, the method names contained an incorrect spelling of "prerelease".

In order to avoid making a breaking change, I left the incorrectly named methods in place in addition to the newly added correctly named methods. Since the incorrectly named methods were only added a few days ago, it is unlikely that they are actually in use as of now. So if you prefer, I am happy to remove the original methods to avoid clutter in the API.

@per1234 per1234 added the bug Something isn't working label Mar 21, 2025
@per1234 per1234 requested a review from cmaglie March 21, 2025 12:17
@codecov
Copy link

codecov bot commented Mar 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (bc29313) to head (71fd327).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #27   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines         1138      1138           
=========================================
  Hits          1138      1138           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cmaglie
Copy link
Member

cmaglie commented Mar 25, 2025

Could you remove the wrong-named methods?
We are still in the "alpha" 0.14.0, so breaking change is permitted.

Previously, the method names contained an incorrect spelling of "prerelease".
@per1234
Copy link
Collaborator Author

per1234 commented Mar 25, 2025

Copy link
Member

@cmaglie cmaglie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @per1234!

@cmaglie cmaglie merged commit 5faa0fa into bugst:master Mar 26, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants