Fix dmenu soft lock; shellcheck; minor enhancements#34
Fix dmenu soft lock; shellcheck; minor enhancements#34Role92 wants to merge 5 commits intobugswriter:masterfrom
Conversation
otherwise it will be sent only after mpv exits
choudhary-akash
left a comment
choudhary-akash
left a comment
There was a problem hiding this comment.
Just remove the quotes around the query variable before echoing it to sed.
| fi | ||
|
|
||
| query="$(echo $query | sed 's/ /+/g')" | ||
| query="$(echo "$query" | sed 's/ /+/g')" |
There was a problem hiding this comment.
It is best not to put quotes around this query variable. Without quotes, if the user entered something like " Suicide Squad " with a bunch of leading and trailing whitespaces, echoing it would automatically remove the leading and trailing spaces and only the space between the words would get replaced by plus sign in the following sed command. So, the output query would be "Suicide+Squad".
Whereas, if you put quotes around the query variable while echoing, it wouldn't remove the extra spaces and all those extra spaces would get converted to plus signs in the following sed command. In this case the output query would be something like "++++++Suicide+Squad++++"
2 participants
No description provided.