Drop unused keys from release profile map #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes KeyErrors in the dump-config logic, which were caused by a mismatch between the Sonarr API response and the current release profile data model. In particular, a KeyError was triggered by `sonarr dump-config` when accessing the `preferred` and `includePreferredWhenRenaming` keys in `config/release.py::_get_remote_map()`. Removing these fields from the remote map fixes the issue. See Buildarr [#219](buildarr/buildarr#219) for more details.
Author
|
Probably need to update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes KeyErrors in the dump-config logic, which were caused by a mismatch between the Sonarr API response and the current release profile data model. Specifically I believe this fixes Sonarr issue #51.
In particular, a KeyError was triggered by
sonarr dump-configwhen accessing thepreferredandincludePreferredWhenRenamingkeys inconfig/release.py::_get_remote_map().Removing these fields from the remote map fixes the issue. See Buildarr issue #219 for more details on the Fix.