Skip to content

Remove bazel module workarounds #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stagnation merged 3 commits into from
Aug 20, 2025
Merged

Remove bazel module workarounds #177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
89d2d0f
Remove re2 module workaround, it is fixed upstream
stagnation Aug 19, 2025
8adcc79
Remove grpc-java workaround, it is solved
stagnation Aug 19, 2025
c48c27a
Remove rules_apple workaround, it is solved
stagnation Aug 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 0 additions & 27 deletions MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,33 +30,6 @@ bazel_dep(name = "rules_shell", version = "0.3.0")
bazel_dep(name = "rules_proto", version = "7.1.0")
bazel_dep(name = "toolchains_llvm", version = "1.4.0")

# # Workarounds 2024-06-27
# ERROR: in tag at https://bcr.bazel.build/modules/grpc-java/1.62.2/MODULE.bazel:89:15: no repository visible as '@com_google_protobuf_javalite' to the repository '@@grpc-java~', but referenced by label '@com_google_protobuf_javalite//:protobuf_javalite' in attribute 'target' of tag 'override'. Is the module 'grpc-java' missing a bazel_dep or use_repo(..., "com_google_protobuf_javalite")?
# https://github.com/grpc/grpc-java/issues/11275
# This can be removed once the dep that introduces `grpc-java` as a transitive
# dependency is updated to use a newer version.
# ├───googleapis@0.0.0-20240326-1c8d509c5
# │ ├───grpc-java@1.64.0 (*)
bazel_dep(name = "grpc-java", version = "1.64.0")

# # Workaround 2025-01-19: For some reason rules_apple fails to build.
# ERROR: Traceback (most recent call last):
# File "/CAS/bazel-cache/f1a15cfb78ca8fde7615be5d21224669/external/rules_apple+/apple/internal/apple_xcframework_import.bzl", line 775, column 21, in <toplevel>
# apple_common.AppleDynamicFramework,
# Error: 'struct' value has no field or method 'AppleDynamicFramework'
single_version_override(
module_name = "rules_apple",
version = "3.19.0",
)

# # Workaround 2025-03-03: re2 has not created a new version yet
# This solves an issue with `bazel mod graph`.
git_override(
module_name = "re2",
commit = "c84a140c93352cdabbfb547c531be34515b12228",
remote = "https://github.com/google/re2",
)

bazel_dep(name = "buildifier_prebuilt", version = "6.4.0", dev_dependency = True)

http_archive = use_repo_rule("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
Expand Down
Loading