-
Notifications
You must be signed in to change notification settings - Fork 80
Make test-deployment-bare run on Windows #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Just a draft for now as I'd like to see how it gets on with the CI here! |
moroten
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Impressive work!
a1508a3 to
c6cc196
Compare
stagnation
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Removing "request changes" to try to get CI to run.)
c6cc196 to
a529b11
Compare
|
I think this is now ready. I got caught out by the github actions windows environment. To cut a long story short, it turns out that sending an interrupt on Windows (which is CTRL_C_EVENT under the hood) requires a console environment. I tried many different ways of creating a console but in the end the only way I found of creating a console environment that was good enough to send a ctrl+c was to use Graceful termination on Windows is a bit of a disaster zone. |
|
Something is not working properly. The Buildbarn deployments exits early and the Bazel build reports exit code 34, but still the Github Workflow succeeds. |
a529b11 to
5a916ae
Compare
|
Thanks for spotting that. I think there's two issues:
|
|
The exit code propagation now works correctly (I added a exit 1 at the end of the script on a branch just to test): https://github.com/tomgr/bb-deployments/actions/runs/17308199155/job/49136347413?pr=3 |
This uses the WinFSP-based VFS implementation.
5a916ae to
8822c72
Compare
|
@tomgr Thank you very much for your excellent work and this contribution! |
|
Hooray! |
This uses the WinFSP-based VFS implementation.