refactor(ci): buildifier check on Aspect

.aspect/workflows/config.yaml

@@ -1,5 +1,6 @@
 # See https://docs.aspect.build/workflows/configuration
 tasks:
   - test:
+  - buildifier:
 notifications:
-  github: {}
+  github: {}

.github/workflows/main.yaml

@@ -6,7 +6,7 @@
          "steps": [
             {
                "name": "Check out source code",
-               "uses": "actions/checkout@v1"
+               "uses": "actions/checkout@v5"
             },
             {
                "name": "Installing Bazel",
@@ -28,11 +28,6 @@
                "name": "Gazelle",
                "run": "rm -f $(find . -name '*.pb.go' | sed -e 's/[^/]*$/BUILD.bazel/') && bazel run //:gazelle"
             },
-            {
-               "if": "matrix.host.lint",
-               "name": "Buildifier",
-               "run": "bazel run @com_github_bazelbuild_buildtools//:buildifier"
-            },
             {
                "if": "matrix.host.lint",
                "name": "Gofmt",

.github/workflows/pull-requests.yaml

@@ -6,7 +6,7 @@
          "steps": [
             {
                "name": "Check out source code",
-               "uses": "actions/checkout@v1"
+               "uses": "actions/checkout@v5"
             },
             {
                "name": "Installing Bazel",
@@ -28,11 +28,6 @@
                "name": "Gazelle",
                "run": "rm -f $(find . -name '*.pb.go' | sed -e 's/[^/]*$/BUILD.bazel/') && bazel run //:gazelle"
             },
-            {
-               "if": "matrix.host.lint",
-               "name": "Buildifier",
-               "run": "bazel run @com_github_bazelbuild_buildtools//:buildifier"
-            },
             {
                "if": "matrix.host.lint",
                "name": "Gofmt",

BUILD.bazel

@@ -25,6 +25,13 @@ buildifier(
     name = "buildifier",
 )
 
+buildifier(
+    name = "buildifier.check",
+    exclude_patterns = ["./.git/*"],
+    lint_mode = "warn",
+    mode = "diff",
+)
+
 npm_link_all_packages(
     name = "node_modules",
 )

tools/container.bzl

@@ -1,3 +1,4 @@
+"Utilities for building and pushing container images for all target platforms."
 load("@rules_oci//oci:defs.bzl", "oci_image", "oci_image_index", "oci_push")
 load("@rules_pkg//pkg:tar.bzl", "pkg_tar")
 

tools/github_workflows/workflows_template.libsonnet

@@ -67,7 +67,7 @@
         // https://github.com/GoogleCloudPlatform/container-definitions/issues/12037
         {
           name: 'Check out source code',
-          uses: 'actions/checkout@v1',
+          uses: 'actions/checkout@v5',
         },
       ] + setupSteps + [
         {
@@ -91,11 +91,6 @@
           run: "rm -f $(find . -name '*.pb.go' | sed -e 's/[^/]*$/BUILD.bazel/') && bazel run //:gazelle",
           'if': 'matrix.host.lint',
         },
-        {
-          name: 'Buildifier',
-          run: 'bazel run @com_github_bazelbuild_buildtools//:buildifier',
-          'if': 'matrix.host.lint',
-        },
         {
           name: 'Gofmt',
           run: 'bazel run @cc_mvdan_gofumpt//:gofumpt -- -w -extra $(pwd)',